tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

f2fs: ensure node page reads complete before f2fs_put_super() finishes

Xfstests generic/335, generic/336 sometimes crash with the following message:

F2FS-fs (dm-0): detect filesystem reference count leak during umount, type: 9, count: 1
------------[ cut here ]------------
kernel BUG at fs/f2fs/super.c:1939!
Oops: invalid opcode: 0000 [#1] SMP NOPTI
CPU: 1 UID: 0 PID: 609351 Comm: umount Tainted: G W 6.17.0-rc5-xfstests-g9dd1835ecda5 #1 PREEMPT(none)
Tainted: [W]=WARN
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2 04/01/2014
RIP: 0010:f2fs_put_super+0x3b3/0x3c0
Call Trace:
<TASK>
generic_shutdown_super+0x7e/0x190
kill_block_super+0x1a/0x40
kill_f2fs_super+0x9d/0x190
deactivate_locked_super+0x30/0xb0
cleanup_mnt+0xba/0x150
task_work_run+0x5c/0xa0
exit_to_user_mode_loop+0xb7/0xc0
do_syscall_64+0x1ae/0x1c0
entry_SYSCALL_64_after_hwframe+0x76/0x7e
</TASK>
---[ end trace 0000000000000000 ]---

It appears that sometimes it is possible that f2fs_put_super() is called before
all node page reads are completed.
Adding a call to f2fs_wait_on_all_pages() for F2FS_RD_NODE fixes the problem.

Cc: stable@kernel.org
Fixes: 20872584b8c0b ("f2fs: fix to drop all dirty meta/node pages during umount()")
Signed-off-by: Jan Prusakowski <jprusakowski@google.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

authored by

Jan Prusakowski and committed by
Jaegeuk Kim 297baa4a 196c81fd

+9 -8
+9 -8
fs/f2fs/super.c
··· 1989 1989 truncate_inode_pages_final(META_MAPPING(sbi)); 1990 1990 } 1991 1991 1992 - for (i = 0; i < NR_COUNT_TYPE; i++) { 1993 - if (!get_pages(sbi, i)) 1994 - continue; 1995 - f2fs_err(sbi, "detect filesystem reference count leak during " 1996 - "umount, type: %d, count: %lld", i, get_pages(sbi, i)); 1997 - f2fs_bug_on(sbi, 1); 1998 - } 1999 - 2000 1992 f2fs_bug_on(sbi, sbi->fsync_node_num); 2001 1993 2002 1994 f2fs_destroy_compress_inode(sbi); ··· 1998 2006 1999 2007 iput(sbi->meta_inode); 2000 2008 sbi->meta_inode = NULL; 2009 + 2010 + /* Should check the page counts after dropping all node/meta pages */ 2011 + for (i = 0; i < NR_COUNT_TYPE; i++) { 2012 + if (!get_pages(sbi, i)) 2013 + continue; 2014 + f2fs_err(sbi, "detect filesystem reference count leak during " 2015 + "umount, type: %d, count: %lld", i, get_pages(sbi, i)); 2016 + f2fs_bug_on(sbi, 1); 2017 + } 2001 2018 2002 2019 /* 2003 2020 * iput() can update stat information, if f2fs_write_checkpoint()