tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: xgbe: use device_get_mac_addr

device_get_mac_addr is basically device_property_read_u8_array with an
is_valid_ether_addr call. Allows just checking for ret.

Remove XGBE_MAC_ADDR_PROPERTY. device_get_mac_addr supports more
properties than just "mac-address".

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Sai Krishna <saikrishnag@marvell.com>
Link: https://patch.msgid.link/20260310194647.3794-1-rosenp@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Rosen Penev and committed by
Jakub Kicinski 29ca1850 72374257

+3 -8
+3 -7
drivers/net/ethernet/amd/xgbe/xgbe-platform.c
··· 252 252 dev_dbg(dev, "sir1_regs = %p\n", pdata->sir1_regs); 253 253 254 254 /* Retrieve the MAC address */ 255 - ret = device_property_read_u8_array(dev, XGBE_MAC_ADDR_PROPERTY, 256 - pdata->mac_addr, 257 - sizeof(pdata->mac_addr)); 258 - if (ret || !is_valid_ether_addr(pdata->mac_addr)) { 259 - dev_err(dev, "invalid %s property\n", XGBE_MAC_ADDR_PROPERTY); 260 - if (!ret) 261 - ret = -EINVAL; 255 + ret = device_get_mac_address(dev, pdata->mac_addr); 256 + if (ret) { 257 + dev_err(dev, "invalid MAC address property\n"); 262 258 goto err_io; 263 259 } 264 260
-1
drivers/net/ethernet/amd/xgbe/xgbe.h
··· 96 96 min_t(unsigned int, IEEE_8021QAZ_MAX_TCS, (_cnt)) 97 97 98 98 /* Common property names */ 99 - #define XGBE_MAC_ADDR_PROPERTY "mac-address" 100 99 #define XGBE_PHY_MODE_PROPERTY "phy-mode" 101 100 #define XGBE_DMA_IRQS_PROPERTY "amd,per-channel-interrupt" 102 101 #define XGBE_SPEEDSET_PROPERTY "amd,speed-set"