Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Input: pwm-vibra - add newline to dev_err prints

Make sure all printed messages end with a newline.

Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>
Reviewed-by: Brian Masney <bmasney@redhat.com>
Reviewed-by: Sebastian Reichel <sre@kernel.org>
Link: https://lore.kernel.org/r/20230427-hammerhead-vibra-v1-2-e87eeb94da51@z3ntu.xyz
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

authored by

Luca Weiss and committed by
Dmitry Torokhov
29ebf697 54e66334

+10 -10
+10 -10
drivers/input/misc/pwm-vibra.c
··· 42 42 if (!vibrator->vcc_on) { 43 43 err = regulator_enable(vibrator->vcc); 44 44 if (err) { 45 - dev_err(pdev, "failed to enable regulator: %d", err); 45 + dev_err(pdev, "failed to enable regulator: %d\n", err); 46 46 return err; 47 47 } 48 48 vibrator->vcc_on = true; ··· 54 54 55 55 err = pwm_apply_state(vibrator->pwm, &state); 56 56 if (err) { 57 - dev_err(pdev, "failed to apply pwm state: %d", err); 57 + dev_err(pdev, "failed to apply pwm state: %d\n", err); 58 58 return err; 59 59 } 60 60 ··· 65 65 66 66 err = pwm_apply_state(vibrator->pwm_dir, &state); 67 67 if (err) { 68 - dev_err(pdev, "failed to apply dir-pwm state: %d", err); 68 + dev_err(pdev, "failed to apply dir-pwm state: %d\n", err); 69 69 pwm_disable(vibrator->pwm); 70 70 return err; 71 71 } ··· 137 137 err = PTR_ERR_OR_ZERO(vibrator->vcc); 138 138 if (err) { 139 139 if (err != -EPROBE_DEFER) 140 - dev_err(&pdev->dev, "Failed to request regulator: %d", 140 + dev_err(&pdev->dev, "Failed to request regulator: %d\n", 141 141 err); 142 142 return err; 143 143 } ··· 146 146 err = PTR_ERR_OR_ZERO(vibrator->pwm); 147 147 if (err) { 148 148 if (err != -EPROBE_DEFER) 149 - dev_err(&pdev->dev, "Failed to request main pwm: %d", 149 + dev_err(&pdev->dev, "Failed to request main pwm: %d\n", 150 150 err); 151 151 return err; 152 152 } ··· 158 158 state.enabled = false; 159 159 err = pwm_apply_state(vibrator->pwm, &state); 160 160 if (err) { 161 - dev_err(&pdev->dev, "failed to apply initial PWM state: %d", 161 + dev_err(&pdev->dev, "failed to apply initial PWM state: %d\n", 162 162 err); 163 163 return err; 164 164 } ··· 172 172 state.enabled = false; 173 173 err = pwm_apply_state(vibrator->pwm_dir, &state); 174 174 if (err) { 175 - dev_err(&pdev->dev, "failed to apply initial PWM state: %d", 175 + dev_err(&pdev->dev, "failed to apply initial PWM state: %d\n", 176 176 err); 177 177 return err; 178 178 } ··· 189 189 break; 190 190 191 191 default: 192 - dev_err(&pdev->dev, "Failed to request direction pwm: %d", err); 192 + dev_err(&pdev->dev, "Failed to request direction pwm: %d\n", err); 193 193 fallthrough; 194 194 195 195 case -EPROBE_DEFER: ··· 207 207 err = input_ff_create_memless(vibrator->input, NULL, 208 208 pwm_vibrator_play_effect); 209 209 if (err) { 210 - dev_err(&pdev->dev, "Couldn't create FF dev: %d", err); 210 + dev_err(&pdev->dev, "Couldn't create FF dev: %d\n", err); 211 211 return err; 212 212 } 213 213 214 214 err = input_register_device(vibrator->input); 215 215 if (err) { 216 - dev_err(&pdev->dev, "Couldn't register input dev: %d", err); 216 + dev_err(&pdev->dev, "Couldn't register input dev: %d\n", err); 217 217 return err; 218 218 } 219 219