Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
Merge branch 'net-wwan-t7xx-add-t7xx-debug-ports'
Jinjian Song says:
====================
net: wwan: t7xx: Add t7xx debug ports
Add support for t7xx WWAN device to debug by ADB (Android Debug Bridge)
port and MTK MIPCi (Modem Information Process Center) port.
Application can use ADB (Android Debug Bridge) port to implement
functions (shell, pull, push ...) by ADB protocol commands.
Application can use MIPC (Modem Information Process Center) port
to debug antenna tuner or noise profiling through this MTK modem
diagnostic interface.
====================
Link: https://patch.msgid.link/20241104094436.466861-1-jinjian.song@fibocom.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
+178
-21
+56
-8
Documentation/networking/device_drivers/wwan/t7xx.rst
+56
-8
Documentation/networking/device_drivers/wwan/t7xx.rst
···
7
7
============================================
8
8
t7xx driver for MTK PCIe based T700 5G modem
9
9
============================================
10
-
The t7xx driver is a WWAN PCIe host driver developed for linux or Chrome OS platforms
11
-
for data exchange over PCIe interface between Host platform & MediaTek's T700 5G modem.
12
-
The driver exposes an interface conforming to the MBIM protocol [1]. Any front end
13
-
application (e.g. Modem Manager) could easily manage the MBIM interface to enable
14
-
data communication towards WWAN. The driver also provides an interface to interact
15
-
with the MediaTek's modem via AT commands.
10
+
The t7xx driver is a WWAN PCIe host driver developed for linux or Chrome OS
11
+
platforms for data exchange over PCIe interface between Host platform &
12
+
MediaTek's T700 5G modem.
13
+
The driver exposes an interface conforming to the MBIM protocol [1]. Any front
14
+
end application (e.g. Modem Manager) could easily manage the MBIM interface to
15
+
enable data communication towards WWAN. The driver also provides an interface
16
+
to interact with the MediaTek's modem via AT commands.
16
17
17
18
Basic usage
18
19
===========
···
46
45
47
46
t7xx_mode
48
47
---------
49
-
The sysfs interface provides userspace with access to the device mode, this interface
50
-
supports read and write operations.
48
+
The sysfs interface provides userspace with access to the device mode, this
49
+
interface supports read and write operations.
51
50
52
51
Device mode:
53
52
···
67
66
68
67
::
69
68
$ echo fastboot_switching > /sys/bus/pci/devices/${bdf}/t7xx_mode
69
+
70
+
t7xx_debug_ports
71
+
----------------
72
+
The sysfs interface provides userspace with access to enable/disable the debug
73
+
ports, this interface supports read and write operations.
74
+
75
+
Debug port status:
76
+
77
+
- ``1`` represents enable debug ports
78
+
- ``0`` represents disable debug ports
79
+
80
+
Currently supported debug ports (ADB/MIPC).
81
+
82
+
Read from userspace to get the current debug ports status.
83
+
84
+
::
85
+
$ cat /sys/bus/pci/devices/${bdf}/t7xx_debug_ports
86
+
87
+
Write from userspace to set the debug ports status.
88
+
89
+
::
90
+
$ echo 1 > /sys/bus/pci/devices/${bdf}/t7xx_debug_ports
70
91
71
92
Management application development
72
93
==================================
···
162
139
port, because device needs a cold reset after enter ``fastboot_switching``
163
140
mode.
164
141
142
+
ADB port userspace ABI
143
+
----------------------
144
+
145
+
/dev/wwan0adb0 character device
146
+
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
147
+
The driver exposes a ADB protocol interface by implementing ADB WWAN Port.
148
+
The userspace end of the ADB channel pipe is a /dev/wwan0adb0 character device.
149
+
Application shall use this interface for ADB protocol communication.
150
+
151
+
MIPC port userspace ABI
152
+
-----------------------
153
+
154
+
/dev/wwan0mipc0 character device
155
+
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
156
+
The driver exposes a diagnostic interface by implementing MIPC (Modem
157
+
Information Process Center) WWAN Port. The userspace end of the MIPC channel
158
+
pipe is a /dev/wwan0mipc0 character device.
159
+
Application shall use this interface for MTK modem diagnostic communication.
160
+
165
161
The MediaTek's T700 modem supports the 3GPP TS 27.007 [4] specification.
166
162
167
163
References
···
206
164
[5] *fastboot "a mechanism for communicating with bootloaders"*
207
165
208
166
- https://android.googlesource.com/platform/system/core/+/refs/heads/main/fastboot/README.md
167
+
168
+
[6] *ADB (Android Debug Bridge) "a mechanism to keep track of Android devices
169
+
and emulators instances connected to or running on a given host developer
170
+
machine with ADB protocol"*
171
+
172
+
- https://android.googlesource.com/platform/packages/modules/adb/+/refs/heads/main/README.md
+1
drivers/net/wwan/t7xx/t7xx_modem_ops.c
+1
drivers/net/wwan/t7xx/t7xx_modem_ops.c
+52
-6
drivers/net/wwan/t7xx/t7xx_pci.c
+52
-6
drivers/net/wwan/t7xx/t7xx_pci.c
···
41
41
#include "t7xx_pcie_mac.h"
42
42
#include "t7xx_reg.h"
43
43
#include "t7xx_state_monitor.h"
44
+
#include "t7xx_port_proxy.h"
44
45
45
46
#define T7XX_PCI_IREG_BASE 0
46
47
#define T7XX_PCI_EREG_BASE 2
···
121
120
122
121
static DEVICE_ATTR_RW(t7xx_mode);
123
122
124
-
static struct attribute *t7xx_mode_attr[] = {
123
+
static ssize_t t7xx_debug_ports_store(struct device *dev,
124
+
struct device_attribute *attr,
125
+
const char *buf, size_t count)
126
+
{
127
+
struct t7xx_pci_dev *t7xx_dev;
128
+
struct pci_dev *pdev;
129
+
bool show;
130
+
int ret;
131
+
132
+
pdev = to_pci_dev(dev);
133
+
t7xx_dev = pci_get_drvdata(pdev);
134
+
if (!t7xx_dev)
135
+
return -ENODEV;
136
+
137
+
ret = kstrtobool(buf, &show);
138
+
if (ret < 0)
139
+
return ret;
140
+
141
+
t7xx_proxy_debug_ports_show(t7xx_dev, show);
142
+
WRITE_ONCE(t7xx_dev->debug_ports_show, show);
143
+
144
+
return count;
145
+
};
146
+
147
+
static ssize_t t7xx_debug_ports_show(struct device *dev,
148
+
struct device_attribute *attr,
149
+
char *buf)
150
+
{
151
+
struct t7xx_pci_dev *t7xx_dev;
152
+
struct pci_dev *pdev;
153
+
bool show;
154
+
155
+
pdev = to_pci_dev(dev);
156
+
t7xx_dev = pci_get_drvdata(pdev);
157
+
if (!t7xx_dev)
158
+
return -ENODEV;
159
+
160
+
show = READ_ONCE(t7xx_dev->debug_ports_show);
161
+
162
+
return sysfs_emit(buf, "%d\n", show);
163
+
}
164
+
165
+
static DEVICE_ATTR_RW(t7xx_debug_ports);
166
+
167
+
static struct attribute *t7xx_attr[] = {
125
168
&dev_attr_t7xx_mode.attr,
169
+
&dev_attr_t7xx_debug_ports.attr,
126
170
NULL
127
171
};
128
172
129
-
static const struct attribute_group t7xx_mode_attribute_group = {
130
-
.attrs = t7xx_mode_attr,
173
+
static const struct attribute_group t7xx_attribute_group = {
174
+
.attrs = t7xx_attr,
131
175
};
132
176
133
177
void t7xx_mode_update(struct t7xx_pci_dev *t7xx_dev, enum t7xx_mode mode)
···
885
839
t7xx_pcie_mac_interrupts_dis(t7xx_dev);
886
840
887
841
ret = sysfs_create_group(&t7xx_dev->pdev->dev.kobj,
888
-
&t7xx_mode_attribute_group);
842
+
&t7xx_attribute_group);
889
843
if (ret)
890
844
goto err_md_exit;
891
845
···
901
855
902
856
err_remove_group:
903
857
sysfs_remove_group(&t7xx_dev->pdev->dev.kobj,
904
-
&t7xx_mode_attribute_group);
858
+
&t7xx_attribute_group);
905
859
906
860
err_md_exit:
907
861
t7xx_md_exit(t7xx_dev);
···
916
870
t7xx_dev = pci_get_drvdata(pdev);
917
871
918
872
sysfs_remove_group(&t7xx_dev->pdev->dev.kobj,
919
-
&t7xx_mode_attribute_group);
873
+
&t7xx_attribute_group);
920
874
t7xx_md_exit(t7xx_dev);
921
875
922
876
for (i = 0; i < EXT_INT_NUM; i++) {
+1
drivers/net/wwan/t7xx/t7xx_pci.h
+1
drivers/net/wwan/t7xx/t7xx_pci.h
+3
drivers/net/wwan/t7xx/t7xx_port.h
+3
drivers/net/wwan/t7xx/t7xx_port.h
···
42
42
/* to AP */
43
43
PORT_CH_AP_CONTROL_RX = 0x1000,
44
44
PORT_CH_AP_CONTROL_TX = 0x1001,
45
+
PORT_CH_AP_ADB_RX = 0x100a,
46
+
PORT_CH_AP_ADB_TX = 0x100b,
45
47
46
48
/* to MD */
47
49
PORT_CH_CONTROL_RX = 0x2000,
···
102
100
struct port_ops *ops;
103
101
char *name;
104
102
enum wwan_port_type port_type;
103
+
bool debug;
105
104
};
106
105
107
106
struct t7xx_port {
+46
-5
drivers/net/wwan/t7xx/t7xx_port_proxy.c
+46
-5
drivers/net/wwan/t7xx/t7xx_port_proxy.c
···
38
38
#include "t7xx_state_monitor.h"
39
39
40
40
#define Q_IDX_CTRL 0
41
-
#define Q_IDX_MBIM 2
41
+
#define Q_IDX_MBIM_MIPC 2
42
+
#define Q_IDX_ADB 3
42
43
#define Q_IDX_AT_CMD 5
43
44
44
45
#define INVALID_SEQ_NUM GENMASK(15, 0)
···
67
66
}, {
68
67
.tx_ch = PORT_CH_MBIM_TX,
69
68
.rx_ch = PORT_CH_MBIM_RX,
70
-
.txq_index = Q_IDX_MBIM,
71
-
.rxq_index = Q_IDX_MBIM,
69
+
.txq_index = Q_IDX_MBIM_MIPC,
70
+
.rxq_index = Q_IDX_MBIM_MIPC,
72
71
.path_id = CLDMA_ID_MD,
73
72
.ops = &wwan_sub_port_ops,
74
73
.name = "MBIM",
···
101
100
.path_id = CLDMA_ID_AP,
102
101
.ops = &ctl_port_ops,
103
102
.name = "t7xx_ap_ctrl",
104
-
},
103
+
}, {
104
+
.tx_ch = PORT_CH_AP_ADB_TX,
105
+
.rx_ch = PORT_CH_AP_ADB_RX,
106
+
.txq_index = Q_IDX_ADB,
107
+
.rxq_index = Q_IDX_ADB,
108
+
.path_id = CLDMA_ID_AP,
109
+
.ops = &wwan_sub_port_ops,
110
+
.name = "adb",
111
+
.port_type = WWAN_PORT_ADB,
112
+
.debug = true,
113
+
}, {
114
+
.tx_ch = PORT_CH_MIPC_TX,
115
+
.rx_ch = PORT_CH_MIPC_RX,
116
+
.txq_index = Q_IDX_MBIM_MIPC,
117
+
.rxq_index = Q_IDX_MBIM_MIPC,
118
+
.path_id = CLDMA_ID_MD,
119
+
.ops = &wwan_sub_port_ops,
120
+
.name = "mipc",
121
+
.port_type = WWAN_PORT_MIPC,
122
+
.debug = true,
123
+
}
105
124
};
106
125
107
126
static const struct t7xx_port_conf t7xx_early_port_conf[] = {
···
526
505
spin_lock_init(&port->port_update_lock);
527
506
port->chan_enable = false;
528
507
529
-
if (port_conf->ops && port_conf->ops->init)
508
+
if (!port_conf->debug &&
509
+
port_conf->ops &&
510
+
port_conf->ops->init)
530
511
port_conf->ops->init(port);
531
512
}
532
513
533
514
t7xx_proxy_setup_ch_mapping(port_prox);
515
+
}
516
+
517
+
void t7xx_proxy_debug_ports_show(struct t7xx_pci_dev *t7xx_dev, bool show)
518
+
{
519
+
struct port_proxy *port_prox = t7xx_dev->md->port_prox;
520
+
struct t7xx_port *port;
521
+
int i;
522
+
523
+
for_each_proxy_port(i, port, port_prox) {
524
+
const struct t7xx_port_conf *port_conf = port->port_conf;
525
+
526
+
if (port_conf->debug && port_conf->ops) {
527
+
if (show && port_conf->ops->init)
528
+
port_conf->ops->init(port);
529
+
else if (!show && port_conf->ops->uninit)
530
+
port_conf->ops->uninit(port);
531
+
}
532
+
}
534
533
}
535
534
536
535
void t7xx_port_proxy_set_cfg(struct t7xx_modem *md, enum port_cfg_id cfg_id)
+1
drivers/net/wwan/t7xx/t7xx_port_proxy.h
+1
drivers/net/wwan/t7xx/t7xx_port_proxy.h
···
98
98
extern struct port_ops t7xx_trace_port_ops;
99
99
#endif
100
100
101
+
void t7xx_proxy_debug_ports_show(struct t7xx_pci_dev *t7xx_dev, bool show);
101
102
void t7xx_port_proxy_reset(struct port_proxy *port_prox);
102
103
void t7xx_port_proxy_uninit(struct port_proxy *port_prox);
103
104
int t7xx_port_proxy_init(struct t7xx_modem *md);
+6
-2
drivers/net/wwan/t7xx/t7xx_port_wwan.c
+6
-2
drivers/net/wwan/t7xx/t7xx_port_wwan.c
···
169
169
{
170
170
const struct t7xx_port_conf *port_conf = port->port_conf;
171
171
172
-
if (port_conf->port_type == WWAN_PORT_FASTBOOT)
172
+
if (port_conf->port_type == WWAN_PORT_FASTBOOT ||
173
+
port_conf->port_type == WWAN_PORT_ADB ||
174
+
port_conf->port_type == WWAN_PORT_MIPC)
173
175
t7xx_port_wwan_create(port);
174
176
175
177
port->rx_length_th = RX_QUEUE_MAXLEN;
···
226
224
{
227
225
const struct t7xx_port_conf *port_conf = port->port_conf;
228
226
229
-
if (port_conf->port_type == WWAN_PORT_FASTBOOT)
227
+
if (port_conf->port_type == WWAN_PORT_FASTBOOT ||
228
+
port_conf->port_type == WWAN_PORT_ADB ||
229
+
port_conf->port_type == WWAN_PORT_MIPC)
230
230
return;
231
231
232
232
if (state != MD_STATE_READY)
+8
drivers/net/wwan/wwan_core.c
+8
drivers/net/wwan/wwan_core.c
···
334
334
.name = "FASTBOOT",
335
335
.devsuf = "fastboot",
336
336
},
337
+
[WWAN_PORT_ADB] = {
338
+
.name = "ADB",
339
+
.devsuf = "adb",
340
+
},
341
+
[WWAN_PORT_MIPC] = {
342
+
.name = "MIPC",
343
+
.devsuf = "mipc",
344
+
},
337
345
};
338
346
339
347
static ssize_t type_show(struct device *dev, struct device_attribute *attr,
+4
include/linux/wwan.h
+4
include/linux/wwan.h
···
17
17
* @WWAN_PORT_FIREHOSE: XML based command protocol
18
18
* @WWAN_PORT_XMMRPC: Control protocol for Intel XMM modems
19
19
* @WWAN_PORT_FASTBOOT: Fastboot protocol control
20
+
* @WWAN_PORT_ADB: ADB protocol control
21
+
* @WWAN_PORT_MIPC: MTK MIPC diagnostic interface
20
22
*
21
23
* @WWAN_PORT_MAX: Highest supported port types
22
24
* @WWAN_PORT_UNKNOWN: Special value to indicate an unknown port type
···
32
30
WWAN_PORT_FIREHOSE,
33
31
WWAN_PORT_XMMRPC,
34
32
WWAN_PORT_FASTBOOT,
33
+
WWAN_PORT_ADB,
34
+
WWAN_PORT_MIPC,
35
35
36
36
/* Add new port types above this line */
37
37