tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/panel: novatek-nt36672a: Don't call unprepare+disable at shutdown/remove

It's the responsibility of a correctly written DRM modeset driver to
call drm_atomic_helper_shutdown() at shutdown time and that should be
disabling / unpreparing the panel if needed. Panel drivers shouldn't
be calling these functions themselves.

A recent effort was made to fix as many DRM modeset drivers as
possible [1] [2] [3] and most drivers are fixed now.

A grep through mainline for compatible strings used by this driver
indicates that it is used by Qualcomm boards. The Qualcomm driver
appears to be correctly calling drm_atomic_helper_shutdown() so we can
remove the calls.

[1] https://lore.kernel.org/r/20230901234015.566018-1-dianders@chromium.org
[2] https://lore.kernel.org/r/20230901234202.566951-1-dianders@chromium.org
[3] https://lore.kernel.org/r/20230921192749.1542462-1-dianders@chromium.org

Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Benni Steini <bennisteinir@gmail.com>
Cc: Marijn Suijten <marijn.suijten@somainline.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Maxime Ripard <mripard@kernel.org>
Tested-by: Joel Selvaraj <jo@jsfamily.in>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240503143327.RFT.v2.19.I67819ba5513d4ef85f254a68b22a3402b4cdf30f@changeid

Douglas Anderson 2a9487b5 b605f257

-17
-17
drivers/gpu/drm/panel/panel-novatek-nt36672a.c
··· 656 656 struct nt36672a_panel *pinfo = mipi_dsi_get_drvdata(dsi); 657 657 int err; 658 658 659 - err = drm_panel_unprepare(&pinfo->base); 660 - if (err < 0) 661 - dev_err(&dsi->dev, "failed to unprepare panel: %d\n", err); 662 - 663 - err = drm_panel_disable(&pinfo->base); 664 - if (err < 0) 665 - dev_err(&dsi->dev, "failed to disable panel: %d\n", err); 666 - 667 659 err = mipi_dsi_detach(dsi); 668 660 if (err < 0) 669 661 dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", err); 670 662 671 663 drm_panel_remove(&pinfo->base); 672 - } 673 - 674 - static void nt36672a_panel_shutdown(struct mipi_dsi_device *dsi) 675 - { 676 - struct nt36672a_panel *pinfo = mipi_dsi_get_drvdata(dsi); 677 - 678 - drm_panel_disable(&pinfo->base); 679 - drm_panel_unprepare(&pinfo->base); 680 664 } 681 665 682 666 static const struct of_device_id tianma_fhd_video_of_match[] = { ··· 676 692 }, 677 693 .probe = nt36672a_panel_probe, 678 694 .remove = nt36672a_panel_remove, 679 - .shutdown = nt36672a_panel_shutdown, 680 695 }; 681 696 module_mipi_dsi_driver(nt36672a_panel_driver); 682 697