tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

watchdog/hpwdt: Remove redundant test.

ProLiants of vintage to have an iLO 5, no longer send watchdog NMI
as an IO CHECK. They are presented to hpwdt_pretimeout as NMI_UNKNOWN.
The preceding if statement rejects if !mynmi irrespective of value
of pretimeout making this if statement redundant.

Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20231213215340.495734-3-jerry.hoemann@hpe.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>

authored by

Jerry Hoemann and committed by
Wim Van Sebroeck 2b276d52 dced0b3e

-3
-3
drivers/watchdog/hpwdt.c
··· 181 181 if (ulReason == NMI_UNKNOWN && !mynmi) 182 182 return NMI_DONE; 183 183 184 - if (ilo5 && !pretimeout && !mynmi) 185 - return NMI_DONE; 186 - 187 184 if (kdumptimeout < 0) 188 185 hpwdt_stop(); 189 186 else if (kdumptimeout == 0)