tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/panel: ltk500hd1829: Stop tracking prepared

As talked about in commit d2aacaf07395 ("drm/panel: Check for already
prepared/enabled in drm_panel"), we want to remove needless code from
panel drivers that was storing and double-checking the
prepared/enabled state. Even if someone was relying on the
double-check before, that double-check is now in the core and not
needed in individual drivers.

Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Maxime Ripard <mripard@kernel.org>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240503143327.RFT.v2.16.I4f574b87fe24765ddd4424437159b37a6481aa1a@changeid

Douglas Anderson 2b8c19b9 b7ca446e

-11
-11
drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c
··· 40 40 struct regulator *vcc; 41 41 struct regulator *iovcc; 42 42 const struct ltk500hd1829_desc *panel_desc; 43 - bool prepared; 44 43 }; 45 44 46 45 static const struct ltk500hd1829_cmd ltk101b4029w_init[] = { ··· 491 492 struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev); 492 493 int ret; 493 494 494 - if (!ctx->prepared) 495 - return 0; 496 - 497 495 ret = mipi_dsi_dcs_set_display_off(dsi); 498 496 if (ret < 0) 499 497 dev_err(panel->dev, "failed to set display off: %d\n", ret); ··· 506 510 regulator_disable(ctx->iovcc); 507 511 regulator_disable(ctx->vcc); 508 512 509 - ctx->prepared = false; 510 - 511 513 return 0; 512 514 } 513 515 ··· 515 521 struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev); 516 522 unsigned int i; 517 523 int ret; 518 - 519 - if (ctx->prepared) 520 - return 0; 521 524 522 525 ret = regulator_enable(ctx->vcc); 523 526 if (ret < 0) { ··· 558 567 dev_err(panel->dev, "failed to set display on: %d\n", ret); 559 568 goto disable_iovcc; 560 569 } 561 - 562 - ctx->prepared = true; 563 570 564 571 return 0; 565 572