Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

lockd: Relocate include/linux/lockd/lockd.h

Headers placed in include/linux/ form part of the kernel's
internal API and signal to subsystem maintainers that other
parts of the kernel may depend on them. By moving lockd.h
into fs/lockd/, lockd becomes a more self-contained module
whose internal interfaces are clearly distinguished from its
public contract with the rest of the kernel. This relocation
addresses a long-standing XXX comment in the header itself
that acknowledged the file's misplacement. Future changes to
lockd internals can now proceed with confidence that external
consumers are not inadvertently coupled to implementation
details.

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

+22 -25
+2 -1
fs/lockd/clnt4xdr.c
··· 13 13 #include <linux/sunrpc/xdr.h> 14 14 #include <linux/sunrpc/clnt.h> 15 15 #include <linux/sunrpc/stats.h> 16 - #include <linux/lockd/lockd.h> 16 + 17 + #include "lockd.h" 17 18 18 19 #include <uapi/linux/nfs3.h> 19 20
+1 -1
fs/lockd/clntlock.c
··· 15 15 #include <linux/sunrpc/addr.h> 16 16 #include <linux/sunrpc/svc.h> 17 17 #include <linux/sunrpc/svc_xprt.h> 18 - #include <linux/lockd/lockd.h> 19 18 #include <linux/kthread.h> 20 19 20 + #include "lockd.h" 21 21 #include "trace.h" 22 22 23 23 #define NLMDBG_FACILITY NLMDBG_CLIENT
+1 -1
fs/lockd/clntproc.c
··· 18 18 #include <linux/freezer.h> 19 19 #include <linux/sunrpc/clnt.h> 20 20 #include <linux/sunrpc/svc.h> 21 - #include <linux/lockd/lockd.h> 22 21 22 + #include "lockd.h" 23 23 #include "trace.h" 24 24 25 25 #define NLMDBG_FACILITY NLMDBG_CLIENT
+2 -1
fs/lockd/clntxdr.c
··· 15 15 #include <linux/sunrpc/xdr.h> 16 16 #include <linux/sunrpc/clnt.h> 17 17 #include <linux/sunrpc/stats.h> 18 - #include <linux/lockd/lockd.h> 18 + 19 + #include "lockd.h" 19 20 20 21 #include <uapi/linux/nfs2.h> 21 22
+1 -1
fs/lockd/host.c
··· 16 16 #include <linux/sunrpc/clnt.h> 17 17 #include <linux/sunrpc/addr.h> 18 18 #include <linux/sunrpc/svc.h> 19 - #include <linux/lockd/lockd.h> 20 19 #include <linux/mutex.h> 21 20 22 21 #include <linux/sunrpc/svc_xprt.h> 23 22 24 23 #include <net/ipv6.h> 25 24 25 + #include "lockd.h" 26 26 #include "netns.h" 27 27 28 28 #define NLMDBG_FACILITY NLMDBG_HOSTCACHE
+1 -1
fs/lockd/mon.c
··· 16 16 #include <linux/sunrpc/addr.h> 17 17 #include <linux/sunrpc/xprtsock.h> 18 18 #include <linux/sunrpc/svc.h> 19 - #include <linux/lockd/lockd.h> 20 19 21 20 #include <linux/unaligned.h> 22 21 22 + #include "lockd.h" 23 23 #include "netns.h" 24 24 25 25 #define NLMDBG_FACILITY NLMDBG_MONITOR
+1 -1
fs/lockd/svc.c
··· 36 36 #include <net/ip.h> 37 37 #include <net/addrconf.h> 38 38 #include <net/ipv6.h> 39 - #include <linux/lockd/lockd.h> 40 39 #include <linux/nfs.h> 41 40 41 + #include "lockd.h" 42 42 #include "netns.h" 43 43 #include "procfs.h" 44 44 #include "netlink.h"
+1 -1
fs/lockd/svc4proc.c
··· 10 10 11 11 #include <linux/types.h> 12 12 #include <linux/time.h> 13 - #include <linux/lockd/lockd.h> 14 13 #include <linux/sunrpc/svc_xprt.h> 15 14 15 + #include "lockd.h" 16 16 #include "share.h" 17 17 #include "xdr4.h" 18 18
+2 -1
fs/lockd/svclock.c
··· 29 29 #include <linux/sunrpc/clnt.h> 30 30 #include <linux/sunrpc/svc_xprt.h> 31 31 #include <linux/lockd/nlm.h> 32 - #include <linux/lockd/lockd.h> 32 + 33 + #include "lockd.h" 33 34 34 35 #define NLMDBG_FACILITY NLMDBG_SVCLOCK 35 36
+1 -1
fs/lockd/svcproc.c
··· 10 10 11 11 #include <linux/types.h> 12 12 #include <linux/time.h> 13 - #include <linux/lockd/lockd.h> 14 13 #include <linux/sunrpc/svc_xprt.h> 15 14 15 + #include "lockd.h" 16 16 #include "share.h" 17 17 18 18 #define NLMDBG_FACILITY NLMDBG_CLIENT
+1 -1
fs/lockd/svcshare.c
··· 14 14 15 15 #include <linux/sunrpc/clnt.h> 16 16 #include <linux/sunrpc/svc.h> 17 - #include <linux/lockd/lockd.h> 18 17 18 + #include "lockd.h" 19 19 #include "share.h" 20 20 21 21 static inline int
+1 -1
fs/lockd/svcsubs.c
··· 15 15 #include <linux/mutex.h> 16 16 #include <linux/sunrpc/svc.h> 17 17 #include <linux/sunrpc/addr.h> 18 - #include <linux/lockd/lockd.h> 19 18 #include <linux/module.h> 20 19 #include <linux/mount.h> 21 20 #include <uapi/linux/nfs2.h> 22 21 22 + #include "lockd.h" 23 23 #include "share.h" 24 24 25 25 #define NLMDBG_FACILITY NLMDBG_SVCSUBS
+2 -1
fs/lockd/trace.h
··· 8 8 #include <linux/tracepoint.h> 9 9 #include <linux/crc32.h> 10 10 #include <linux/nfs.h> 11 - #include <linux/lockd/lockd.h> 11 + 12 + #include "lockd.h" 12 13 13 14 #ifdef CONFIG_LOCKD_V4 14 15 #define NLM_STATUS_LIST \
+1 -2
fs/lockd/xdr.c
··· 15 15 #include <linux/sunrpc/clnt.h> 16 16 #include <linux/sunrpc/svc.h> 17 17 #include <linux/sunrpc/stats.h> 18 - #include <linux/lockd/lockd.h> 19 18 20 19 #include <uapi/linux/nfs2.h> 21 20 21 + #include "lockd.h" 22 22 #include "svcxdr.h" 23 - 24 23 25 24 static inline loff_t 26 25 s32_to_loff_t(__s32 offset)
+1 -1
fs/lockd/xdr4.c
··· 16 16 #include <linux/sunrpc/clnt.h> 17 17 #include <linux/sunrpc/svc.h> 18 18 #include <linux/sunrpc/stats.h> 19 - #include <linux/lockd/lockd.h> 20 19 20 + #include "lockd.h" 21 21 #include "svcxdr.h" 22 22 #include "xdr4.h" 23 23
+3 -9
include/linux/lockd/lockd.h fs/lockd/lockd.h
··· 1 1 /* SPDX-License-Identifier: GPL-2.0 */ 2 2 /* 3 - * linux/include/linux/lockd/lockd.h 4 - * 5 - * General-purpose lockd include file. 6 - * 7 3 * Copyright (C) 1996 Olaf Kirch <okir@monad.swb.de> 8 4 */ 9 5 10 - #ifndef LINUX_LOCKD_LOCKD_H 11 - #define LINUX_LOCKD_LOCKD_H 12 - 13 - /* XXX: a lot of this should really be under fs/lockd. */ 6 + #ifndef _LOCKD_LOCKD_H 7 + #define _LOCKD_LOCKD_H 14 8 15 9 #include <linux/exportfs.h> 16 10 #include <linux/in.h> ··· 392 398 393 399 extern const struct lock_manager_operations nlmsvc_lock_operations; 394 400 395 - #endif /* LINUX_LOCKD_LOCKD_H */ 401 + #endif /* _LOCKD_LOCKD_H */