tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

scsi: qla2xxx: Define static symbols

drivers/scsi/qla2xxx/qla_os.c:40:20: warning: symbol 'qla_trc_array'
was not declared. Should it be static?
drivers/scsi/qla2xxx/qla_os.c:345:5: warning: symbol
'ql2xdelay_before_pci_error_handling' was not declared.
Should it be static?

Define qla_trc_array and ql2xdelay_before_pci_error_handling as static to
fix sparse warnings.

Link: https://lore.kernel.org/r/20220826102559.17474-7-njavali@marvell.com
Cc: stable@vger.kernel.org
Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Nilesh Javali and committed by
Martin K. Petersen 2c57d0de 8bfc149b

+2 -2
+2 -2
drivers/scsi/qla2xxx/qla_os.c
··· 37 37 */ 38 38 struct kmem_cache *srb_cachep; 39 39 40 - struct trace_array *qla_trc_array; 40 + static struct trace_array *qla_trc_array; 41 41 42 42 int ql2xfulldump_on_mpifail; 43 43 module_param(ql2xfulldump_on_mpifail, int, S_IRUGO | S_IWUSR); ··· 342 342 "To wait for ABTS response on I/O timeouts for NVMe. (default: 1)"); 343 343 344 344 345 - u32 ql2xdelay_before_pci_error_handling = 5; 345 + static u32 ql2xdelay_before_pci_error_handling = 5; 346 346 module_param(ql2xdelay_before_pci_error_handling, uint, 0644); 347 347 MODULE_PARM_DESC(ql2xdelay_before_pci_error_handling, 348 348 "Number of seconds delayed before qla begin PCI error self-handling (default: 5).\n");