tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

afs: Read of file returns EBADMSG

A read of a large file on an afs mount failed:

# cat junk.file > /dev/null
cat: junk.file: Bad message

Looking at the trace, call->offset wrapped since it is only an
unsigned short. In afs_extract_data:

_enter("{%u},{%zu},%d,,%zu", call->offset, len, last, count);
...

if (call->offset < count) {
if (last) {
_leave(" = -EBADMSG [%d < %zu]", call->offset, count);
return -EBADMSG;
}

Which matches the trace:

[cat ] ==> afs_extract_data({65132},{524},1,,65536)
[cat ] <== afs_extract_data() = -EBADMSG [0 < 65536]

call->offset went from 65132 to 0. Fix this by making call->offset an
unsigned int.

Signed-off-by: Anton Blanchard <anton@samba.org>
Signed-off-by: David Howells <dhowells@redhat.com>
Cc: <stable@kernel.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Anton Blanchard and committed by
Linus Torvalds 2c724fb9 0c4d0670

+1 -1
+1 -1
fs/afs/internal.h
··· 109 109 unsigned reply_size; /* current size of reply */ 110 110 unsigned first_offset; /* offset into mapping[first] */ 111 111 unsigned last_to; /* amount of mapping[last] */ 112 - unsigned short offset; /* offset into received data store */ 112 + unsigned offset; /* offset into received data store */ 113 113 unsigned char unmarshall; /* unmarshalling phase */ 114 114 bool incoming; /* T if incoming call */ 115 115 bool send_pages; /* T if data from mapping should be sent */