tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

usb: gadget: f_hid: Add missing error code

Currently in cdev_alloc() error path no error code is assigned.

Assign error code '-ENOMEM'.

Detected by Smatch:
drivers/usb/gadget/function/f_hid.c:1291 hidg_bind()
warn: missing error code 'status'

Fixes: 81ebd43cc0d6d ("usb: gadget: f_hid: don't call cdev_init while cdev in use")
Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
Acked-by: Peter Korsgaard <peter@korsgaard.com>
Reviewed-by: Michael Zimmermann <sigmaepsilon92@gmail.com>
Link: https://patch.msgid.link/20260402180008.64233-1-ethantidmore06@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Ethan Tidmore and committed by
Greg Kroah-Hartman 2c863dbb 40b17a34

+3 -1
+3 -1
drivers/usb/gadget/function/f_hid.c
··· 1278 1278 1279 1279 /* create char device */ 1280 1280 hidg->cdev = cdev_alloc(); 1281 - if (!hidg->cdev) 1281 + if (!hidg->cdev) { 1282 + status = -ENOMEM; 1282 1283 goto fail_free_all; 1284 + } 1283 1285 hidg->cdev->ops = &f_hidg_fops; 1284 1286 1285 1287 status = cdev_device_add(hidg->cdev, &hidg->dev);