tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: usb: cdc_ether: don't spew notifications

The usbnet_link_change function is not called, if the link has not changed.

...
[16913.807393][ 3] cdc_ether 1-2:2.0 enx00e0995fd1ac: kevent 12 may have been dropped
[16913.822266][ 2] cdc_ether 1-2:2.0 enx00e0995fd1ac: kevent 12 may have been dropped
[16913.826296][ 2] cdc_ether 1-2:2.0 enx00e0995fd1ac: kevent 11 may have been dropped
...

kevent 11 is scheduled too frequently and may affect other event schedules.

Signed-off-by: zhangxiangqian <zhangxiangqian@kylinos.cn>
Acked-by: Oliver Neukum <oneukum@suse.com>
Link: https://patch.msgid.link/1723109985-11996-1-git-send-email-zhangxiangqian@kylinos.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

zhangxiangqian and committed by
Jakub Kicinski 2d5c9dd2 916b7d31

+2 -1
+2 -1
drivers/net/usb/cdc_ether.c
··· 418 418 case USB_CDC_NOTIFY_NETWORK_CONNECTION: 419 419 netif_dbg(dev, timer, dev->net, "CDC: carrier %s\n", 420 420 event->wValue ? "on" : "off"); 421 - usbnet_link_change(dev, !!event->wValue, 0); 421 + if (netif_carrier_ok(dev->net) != !!event->wValue) 422 + usbnet_link_change(dev, !!event->wValue, 0); 422 423 break; 423 424 case USB_CDC_NOTIFY_SPEED_CHANGE: /* tx/rx rates */ 424 425 netif_dbg(dev, timer, dev->net, "CDC: speed change (len %d)\n",