tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

scsi: qedi: Replace all non-returning strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230517143509.1520387-1-azeemshaikh38@gmail.com

authored by

Azeem Shaikh and committed by
Kees Cook 2f4113b3 3b92d34a

+1 -1
+1 -1
drivers/scsi/qedi/qedi_main.c
··· 2593 2593 sp_params.drv_minor = QEDI_DRIVER_MINOR_VER; 2594 2594 sp_params.drv_rev = QEDI_DRIVER_REV_VER; 2595 2595 sp_params.drv_eng = QEDI_DRIVER_ENG_VER; 2596 - strlcpy(sp_params.name, "qedi iSCSI", QED_DRV_VER_STR_SIZE); 2596 + strscpy(sp_params.name, "qedi iSCSI", QED_DRV_VER_STR_SIZE); 2597 2597 rc = qedi_ops->common->slowpath_start(qedi->cdev, &sp_params); 2598 2598 if (rc) { 2599 2599 QEDI_ERR(&qedi->dbg_ctx, "Cannot start slowpath\n");