Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

watchdog: starfive-wdt: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20231106154807.3866712-5-u.kleine-koenig@pengutronix.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>

authored by

Uwe Kleine-König and committed by
Wim Van Sebroeck
2faef275 6a7b3de6

+2 -4
+2 -4
drivers/watchdog/starfive-wdt.c
··· 504 504 return ret; 505 505 } 506 506 507 - static int starfive_wdt_remove(struct platform_device *pdev) 507 + static void starfive_wdt_remove(struct platform_device *pdev) 508 508 { 509 509 struct starfive_wdt *wdt = platform_get_drvdata(pdev); 510 510 ··· 516 516 else 517 517 /* disable clock without PM */ 518 518 starfive_wdt_disable_clock(wdt); 519 - 520 - return 0; 521 519 } 522 520 523 521 static void starfive_wdt_shutdown(struct platform_device *pdev) ··· 585 587 586 588 static struct platform_driver starfive_wdt_driver = { 587 589 .probe = starfive_wdt_probe, 588 - .remove = starfive_wdt_remove, 590 + .remove_new = starfive_wdt_remove, 589 591 .shutdown = starfive_wdt_shutdown, 590 592 .driver = { 591 593 .name = "starfive-wdt",