Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

sched_ext: Use WRITE_ONCE() for the write side of scx_enable helper pointer

scx_enable() uses double-checked locking to lazily initialize a static
kthread_worker pointer. The fast path reads helper locklessly:

if (!READ_ONCE(helper)) { // lockless read -- no helper_mutex

The write side initializes helper under helper_mutex, but previously
used a plain assignment:

helper = kthread_run_worker(0, "scx_enable_helper");
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
plain write -- KCSAN data race with READ_ONCE() above

Since READ_ONCE() on the fast path and the plain write on the
initialization path access the same variable without a common lock,
they constitute a data race. KCSAN requires that all sides of a
lock-free access use READ_ONCE()/WRITE_ONCE() consistently.

Use a temporary variable to stage the result of kthread_run_worker(),
and only WRITE_ONCE() into helper after confirming the pointer is
valid. This avoids a window where a concurrent caller on the fast path
could observe an ERR pointer via READ_ONCE(helper) before the error
check completes.

Fixes: b06ccbabe250 ("sched_ext: Fix starvation of scx_enable() under fair-class saturation")
Signed-off-by: zhidao su <suzhidao@xiaomi.com>
Acked-by: Andrea Righi <arighi@nvidia.com>
Signed-off-by: Tejun Heo <tj@kernel.org>

authored by

zhidao su and committed by
Tejun Heo
2fcfe595 57ccf5cc

+5 -4
+5 -4
kernel/sched/ext.c
··· 5258 5258 if (!READ_ONCE(helper)) { 5259 5259 mutex_lock(&helper_mutex); 5260 5260 if (!helper) { 5261 - helper = kthread_run_worker(0, "scx_enable_helper"); 5262 - if (IS_ERR_OR_NULL(helper)) { 5263 - helper = NULL; 5261 + struct kthread_worker *w = 5262 + kthread_run_worker(0, "scx_enable_helper"); 5263 + if (IS_ERR_OR_NULL(w)) { 5264 5264 mutex_unlock(&helper_mutex); 5265 5265 return -ENOMEM; 5266 5266 } 5267 - sched_set_fifo(helper->task); 5267 + sched_set_fifo(w->task); 5268 + WRITE_ONCE(helper, w); 5268 5269 } 5269 5270 mutex_unlock(&helper_mutex); 5270 5271 }