Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

lib/sys_info: handle sys_info_mask==0 case

Generalization of panic_print's dump function [1] has been merged, and
this patchset is to address some remaining issues, like adding note of the
obsoletion of 'panic_print' cmdline parameter, refining the kernel
document for panic_print, and hardening some string management.


This patch (of 4):

It is a normal case that bitmask parameter is 0, so pre-initialize the
names[] to null string to cover this case.

Also remove the superfluous "+1" in names[sizeof(sys_info_avail) + 1],
which is needed for 'strlen()', but not for 'sizeof()'.

Link: https://lkml.kernel.org/r/20250825025701.81921-1-feng.tang@linux.alibaba.com
Link: https://lkml.kernel.org/r/20250825025701.81921-2-feng.tang@linux.alibaba.com
Link: Link: https://lkml.kernel.org/r/20250703021004.42328-1-feng.tang@linux.alibaba.com [1]
Signed-off-by: Feng Tang <feng.tang@linux.alibaba.com>
Suggested-by: Petr Mladek <pmladek@suse.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Cc: Askar Safin <safinaskar@zohomail.com>
Cc: John Ogness <john.ogness@linutronix.de>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Lance Yang <lance.yang@linux.dev>
Cc: "Paul E . McKenney" <paulmck@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

Feng Tang and committed by
Andrew Morton
31cf021b 13818f7b

+2 -1
+2 -1
lib/sys_info.c
··· 55 55 void *buffer, size_t *lenp, 56 56 loff_t *ppos) 57 57 { 58 - char names[sizeof(sys_info_avail) + 1]; 58 + char names[sizeof(sys_info_avail)]; 59 59 struct ctl_table table; 60 60 unsigned long *si_bits_global; 61 61 ··· 81 81 char *delim = ""; 82 82 int i, len = 0; 83 83 84 + names[0] = '\0'; 84 85 for (i = 0; i < ARRAY_SIZE(si_names); i++) { 85 86 if (*si_bits_global & si_names[i].bit) { 86 87 len += scnprintf(names + len, sizeof(names) - len,