Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
driver core: bus: constantify subsys_register() calls
The functions subsys_register() and subsys_virtual_register() should be
taking a constant pointer to a struct bus_type, as they do not actually
modify anything in it, so fix up the function definitions to do so
properly.
This also changes the pointer type in struct subsys_interface to be
constant as well, as again, that's the proper signature of it.
Cc: Rafael J. Wysocki <rafael@kernel.org>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/2023121908-grove-genetics-f8af@gregkh
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+6
-6
+3
-3
drivers/base/bus.c
+3
-3
drivers/base/bus.c
···
1194
1194
kfree(dev);
1195
1195
}
1196
1196
1197
-
static int subsys_register(struct bus_type *subsys,
1197
+
static int subsys_register(const struct bus_type *subsys,
1198
1198
const struct attribute_group **groups,
1199
1199
struct kobject *parent_of_root)
1200
1200
{
···
1264
1264
* directory itself and not some create fake root-device placed in
1265
1265
* /sys/devices/system/<name>.
1266
1266
*/
1267
-
int subsys_system_register(struct bus_type *subsys,
1267
+
int subsys_system_register(const struct bus_type *subsys,
1268
1268
const struct attribute_group **groups)
1269
1269
{
1270
1270
return subsys_register(subsys, groups, &system_kset->kobj);
···
1282
1282
* There's no restriction on device naming. This is for kernel software
1283
1283
* constructs which need sysfs interface.
1284
1284
*/
1285
-
int subsys_virtual_register(struct bus_type *subsys,
1285
+
int subsys_virtual_register(const struct bus_type *subsys,
1286
1286
const struct attribute_group **groups)
1287
1287
{
1288
1288
struct kobject *virtual_dir;
+3
-3
include/linux/device.h
+3
-3
include/linux/device.h
···
63
63
*/
64
64
struct subsys_interface {
65
65
const char *name;
66
-
struct bus_type *subsys;
66
+
const struct bus_type *subsys;
67
67
struct list_head node;
68
68
int (*add_dev)(struct device *dev, struct subsys_interface *sif);
69
69
void (*remove_dev)(struct device *dev, struct subsys_interface *sif);
···
72
72
int subsys_interface_register(struct subsys_interface *sif);
73
73
void subsys_interface_unregister(struct subsys_interface *sif);
74
74
75
-
int subsys_system_register(struct bus_type *subsys,
75
+
int subsys_system_register(const struct bus_type *subsys,
76
76
const struct attribute_group **groups);
77
-
int subsys_virtual_register(struct bus_type *subsys,
77
+
int subsys_virtual_register(const struct bus_type *subsys,
78
78
const struct attribute_group **groups);
79
79
80
80
/*