Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/log: Do not hold lock across drm_client_release()

When calling drm_client_release(), the client is already quiescent.
Internal locks should therefore be dropped before the caller releases
the client.

In the case of the DRM log, concurrency originates from the console or
from client events. The console has been unregistered in the previous
line. The caller of the unregister callback, drm_log_client_unregister(),
holds clientlist_mutex from struct drm_device to protect against concurrent
client events. It is therefore safe to release the client without holding
locks.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>>
Link: https://lore.kernel.org/r/20251009132006.45834-3-tzimmermann@suse.de

+1 -1
+1 -1
drivers/gpu/drm/clients/drm_log.c
··· 302 302 303 303 mutex_lock(&dlog->lock); 304 304 drm_log_free_scanout(client); 305 - drm_client_release(client); 306 305 mutex_unlock(&dlog->lock); 306 + drm_client_release(client); 307 307 kfree(dlog); 308 308 drm_dbg(dev, "Unregistered with drm log\n"); 309 309 }