Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

fbdev: flush deferred IO before closing

When framebuffer gets closed, the queued deferred IO gets cancelled. This
can cause some last display data to vanish. This is problematic for users
who send a still image to the framebuffer, then close the file: the image
may never appear.

To ensure none of display data get lost, flush the queued deferred IO
first before closing.

Another possible solution is to delete the cancel_delayed_work_sync()
instead. The difference is that the display may appear some time after
closing. However, the clearing of page mapping after this needs to be
removed too, because the page mapping is used by the deferred work. It is
not completely obvious whether it is okay to not clear the page mapping.
For a patch intended for stable trees, go with the simple and obvious
solution.

Fixes: 60b59beafba8 ("fbdev: mm: Deferred IO support")
Cc: stable@vger.kernel.org
Signed-off-by: Nam Cao <namcao@linutronix.de>
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Helge Deller <deller@gmx.de>

authored by

Nam Cao and committed by
Helge Deller
33cd6ea9 15e4c1f4

+1 -1
+1 -1
drivers/video/fbdev/core/fb_defio.c
··· 313 313 struct page *page; 314 314 int i; 315 315 316 - cancel_delayed_work_sync(&info->deferred_work); 316 + flush_delayed_work(&info->deferred_work); 317 317 318 318 /* clear out the mapping that we setup */ 319 319 for (i = 0 ; i < info->fix.smem_len; i += PAGE_SIZE) {