tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

misc: lan966x_pci: Fix dtc warns 'missing or empty reg/ranges property'

dtc generates the following warnings when building the LAN966x device
tree overlay (lan966x_pci.dtso):
Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/cpu_clk: missing or empty reg/ranges property
Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/ddr_clk: missing or empty reg/ranges property
Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/sys_clk: missing or empty reg/ranges property

Indeed, related nodes are under the pci-ep-bus (simple-bus) which is not
correct.

Put them outside this node.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/all/20241025110919.64b1cffb@canb.auug.org.au/
Fixes: 185686beb464 ("misc: Add support for LAN966x PCI device")
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Link: https://lore.kernel.org/r/20241029084338.194942-2-herve.codina@bootlin.com
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

authored by

Herve Codina and committed by
Philipp Zabel 344ea0d3 37b395c2

+18 -18
+18 -18
drivers/misc/lan966x_pci.dtso
··· 19 19 #address-cells = <3>; 20 20 #size-cells = <2>; 21 21 22 + cpu_clk: clock-600000000 { 23 + compatible = "fixed-clock"; 24 + #clock-cells = <0>; 25 + clock-frequency = <600000000>; /* CPU clock = 600MHz */ 26 + }; 27 + 28 + ddr_clk: clock-30000000 { 29 + compatible = "fixed-clock"; 30 + #clock-cells = <0>; 31 + clock-frequency = <30000000>; /* Fabric clock = 30MHz */ 32 + }; 33 + 34 + sys_clk: clock-15625000 { 35 + compatible = "fixed-clock"; 36 + #clock-cells = <0>; 37 + clock-frequency = <15625000>; /* System clock = 15.625MHz */ 38 + }; 39 + 22 40 pci-ep-bus@0 { 23 41 compatible = "simple-bus"; 24 42 #address-cells = <1>; ··· 55 37 interrupt-controller; 56 38 interrupts = <0>; /* PCI INTx assigned interrupt */ 57 39 reg = <0xe00c0120 0x190>; 58 - }; 59 - 60 - cpu_clk: cpu_clk { 61 - compatible = "fixed-clock"; 62 - #clock-cells = <0>; 63 - clock-frequency = <600000000>; // CPU clock = 600MHz 64 - }; 65 - 66 - ddr_clk: ddr_clk { 67 - compatible = "fixed-clock"; 68 - #clock-cells = <0>; 69 - clock-frequency = <30000000>; // Fabric clock = 30MHz 70 - }; 71 - 72 - sys_clk: sys_clk { 73 - compatible = "fixed-clock"; 74 - #clock-cells = <0>; 75 - clock-frequency = <15625000>; // System clock = 15.625MHz 76 40 }; 77 41 78 42 cpu_ctrl: syscon@e00c0000 {