Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

io_uring/io-wq: always retry worker create on ERESTART*

If a task has a pending signal when create_io_thread() is called,
copy_process() will return -ERESTARTNOINTR. io_should_retry_thread()
will request a retry of create_io_thread() up to WORKER_INIT_LIMIT = 3
times. If all retries fail, the io_uring request will fail with
ECANCELED.
Commit 3918315c5dc ("io-wq: backoff when retrying worker creation")
added a linear backoff to allow the thread to handle its signal before
the retry. However, a thread receiving frequent signals may get unlucky
and have a signal pending at every retry. Since the userspace task
doesn't control when it receives signals, there's no easy way for it to
prevent the create_io_thread() failure due to pending signals. The task
may also lack the information necessary to regenerate the canceled SQE.
So always retry the create_io_thread() on the ERESTART* errors,
analogous to what a fork() syscall would do. EAGAIN can occur due to
various persistent conditions such as exceeding RLIMIT_NPROC, so respect
the WORKER_INIT_LIMIT retry limit for EAGAIN errors.

Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

authored by

Caleb Sander Mateos and committed by
Jens Axboe
34c78b86 84230ad2

+3 -2
+3 -2
io_uring/io-wq.c
··· 805 805 */ 806 806 if (fatal_signal_pending(current)) 807 807 return false; 808 - if (worker->init_retries++ >= WORKER_INIT_LIMIT) 809 - return false; 810 808 809 + worker->init_retries++; 811 810 switch (err) { 812 811 case -EAGAIN: 812 + return worker->init_retries <= WORKER_INIT_LIMIT; 813 + /* Analogous to a fork() syscall, always retry on a restartable error */ 813 814 case -ERESTARTSYS: 814 815 case -ERESTARTNOINTR: 815 816 case -ERESTARTNOHAND: