Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
iio: frequency: adf4371: make use of dev_err_probe()
Use dev_err_probe() to simplify probe() error handling. While at it, add
some error log in case we fail to get clkin.
Signed-off-by: Nuno Sa <nuno.sa@analog.com>
Link: https://patch.msgid.link/20241009-dev-adf4371-minor-improv-v1-4-97f4f22ed941@analog.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
authored by
Nuno Sa
and committed by
Jonathan Cameron
3681313a
eec91fc8
+8
-10
+8
-10
drivers/iio/frequency/adf4371.c
+8
-10
drivers/iio/frequency/adf4371.c
···
4
4
*
5
5
* Copyright 2019 Analog Devices Inc.
6
6
*/
7
+
#include "linux/dev_printk.h"
7
8
#include <linux/bitfield.h>
8
9
#include <linux/clk.h>
9
10
#include <linux/device.h>
···
555
554
return -ENOMEM;
556
555
557
556
regmap = devm_regmap_init_spi(spi, &adf4371_regmap_config);
558
-
if (IS_ERR(regmap)) {
559
-
dev_err(&spi->dev, "Error initializing spi regmap: %ld\n",
560
-
PTR_ERR(regmap));
561
-
return PTR_ERR(regmap);
562
-
}
557
+
if (IS_ERR(regmap))
558
+
return dev_err_probe(&spi->dev, PTR_ERR(regmap),
559
+
"Error initializing spi regmap\n");
563
560
564
561
st = iio_priv(indio_dev);
565
562
st->spi = spi;
···
576
577
577
578
clkin = devm_clk_get_enabled(&spi->dev, "clkin");
578
579
if (IS_ERR(clkin))
579
-
return PTR_ERR(clkin);
580
+
return dev_err_probe(&spi->dev, PTR_ERR(clkin),
581
+
"Failed to get clkin\n");
580
582
581
583
st->clkin_freq = clk_get_rate(clkin);
582
584
583
585
ret = adf4371_setup(st);
584
-
if (ret < 0) {
585
-
dev_err(&spi->dev, "ADF4371 setup failed\n");
586
-
return ret;
587
-
}
586
+
if (ret < 0)
587
+
return dev_err_probe(&spi->dev, ret, "ADF4371 setup failed\n");
588
588
589
589
return devm_iio_device_register(&spi->dev, indio_dev);
590
590
}