tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

iio: adc: ti-ads1119: Replace IRQF_ONESHOT with IRQF_NO_THREAD

As there is no threaded handler, replace devm_request_threaded_irq()
with devm_request_irq(), and as the handler calls iio_trigger_poll()
which may not be called from a threaded handler replace IRQF_ONESHOT
with IRQF_NO_THREAD.

Since commit aef30c8d569c ("genirq: Warn about using IRQF_ONESHOT
without a threaded handler"), the IRQ core checks IRQF_ONESHOT flag
in IRQ request and gives a warning if there is no threaded handler.

Fixes: a9306887eba4 ("iio: adc: ti-ads1119: Add driver")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Reviewed-by: David Lechner <dlechner@baylibre.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

authored by

Felix Gu and committed by
Jonathan Cameron 36f6d4db 773ef9f9

+2 -4
+2 -4
drivers/iio/adc/ti-ads1119.c
··· 735 735 return dev_err_probe(dev, ret, "Failed to setup IIO buffer\n"); 736 736 737 737 if (client->irq > 0) { 738 - ret = devm_request_threaded_irq(dev, client->irq, 739 - ads1119_irq_handler, 740 - NULL, IRQF_ONESHOT, 741 - "ads1119", indio_dev); 738 + ret = devm_request_irq(dev, client->irq, ads1119_irq_handler, 739 + IRQF_NO_THREAD, "ads1119", indio_dev); 742 740 if (ret) 743 741 return dev_err_probe(dev, ret, 744 742 "Failed to allocate irq\n");