tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

s390/iucv: Convert sprintf/snprintf to scnprintf

Convert sprintf/snprintf calls to scnprintf to better align with the
kernel development community practices [1].

Link: https://lwn.net/Articles/69419 [1]
Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>
Signed-off-by: Aswin Karuvally <aswin@linux.ibm.com>
Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20251017094954.1402684-1-wintera@linux.ibm.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Aswin Karuvally and committed by
Jakub Kicinski 38516e3f baa515ef

+9 -7
+4 -3
drivers/s390/net/smsgiucv_app.c
··· 88 88 ev->envp[3] = NULL; 89 89 90 90 /* setting up environment: sender, prefix name, and message text */ 91 - snprintf(ev->envp[0], ENV_SENDER_LEN, ENV_SENDER_STR "%s", from); 92 - snprintf(ev->envp[1], ENV_PREFIX_LEN, ENV_PREFIX_STR "%s", SMSG_PREFIX); 93 - snprintf(ev->envp[2], ENV_TEXT_LEN(msg), ENV_TEXT_STR "%s", msg); 91 + scnprintf(ev->envp[0], ENV_SENDER_LEN, ENV_SENDER_STR "%s", from); 92 + scnprintf(ev->envp[1], ENV_PREFIX_LEN, ENV_PREFIX_STR "%s", 93 + SMSG_PREFIX); 94 + scnprintf(ev->envp[2], ENV_TEXT_LEN(msg), ENV_TEXT_STR "%s", msg); 94 95 95 96 return ev; 96 97 }
+4 -3
net/iucv/af_iucv.c
··· 553 553 { 554 554 char name[12]; 555 555 556 - sprintf(name, "%08x", atomic_inc_return(&iucv_sk_list.autobind_name)); 556 + scnprintf(name, sizeof(name), 557 + "%08x", atomic_inc_return(&iucv_sk_list.autobind_name)); 557 558 while (__iucv_get_sock_by_name(name)) { 558 - sprintf(name, "%08x", 559 - atomic_inc_return(&iucv_sk_list.autobind_name)); 559 + scnprintf(name, sizeof(name), "%08x", 560 + atomic_inc_return(&iucv_sk_list.autobind_name)); 560 561 } 561 562 memcpy(iucv->src_name, name, 8); 562 563 }
+1 -1
net/iucv/iucv.c
··· 95 95 if (!dev) 96 96 goto out_error; 97 97 va_start(vargs, fmt); 98 - vsnprintf(buf, sizeof(buf), fmt, vargs); 98 + vscnprintf(buf, sizeof(buf), fmt, vargs); 99 99 rc = dev_set_name(dev, "%s", buf); 100 100 va_end(vargs); 101 101 if (rc)