tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: ll_temac: platform_get_resource replaced by wrong function

The function platform_get_resource was replaced with
devm_platform_ioremap_resource_byname and is called using 0 as name.

This eventually ends up in platform_get_resource_byname in the call
stack, where it causes a null pointer in strcmp.

if (type == resource_type(r) && !strcmp(r->name, name))

It should have been replaced with devm_platform_ioremap_resource.

Fixes: bd69058f50d5 ("net: ll_temac: Use devm_platform_ioremap_resource_byname()")
Signed-off-by: Claus Hansen Ries <chr@terma.com>
Cc: stable@vger.kernel.org
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/cca18f9c630a41c18487729770b492bb@terma.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Claus Hansen Ries and committed by
Jakub Kicinski 3a38a829 afb373ff

+1 -1
+1 -1
drivers/net/ethernet/xilinx/ll_temac_main.c
··· 1443 1443 } 1444 1444 1445 1445 /* map device registers */ 1446 - lp->regs = devm_platform_ioremap_resource_byname(pdev, 0); 1446 + lp->regs = devm_platform_ioremap_resource(pdev, 0); 1447 1447 if (IS_ERR(lp->regs)) { 1448 1448 dev_err(&pdev->dev, "could not map TEMAC registers\n"); 1449 1449 return -ENOMEM;