tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/gma500: fix potential NULL pointer dereference dereference

NULL check at line 528: if (!sender || !data_out || !len_out) {, implies
that pointer _sender_ might be NULL.

Move pointer _sender_ dereference after NULL check in order to avoid a
potential NULL pointer dereference.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20170812015515.GA8360@embeddedgus

authored by

Gustavo A. R. Silva and committed by
Daniel Vetter 3c2c42eb f3bbc908

+3 -1
+3 -1
drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
··· 520 520 u8 *data, u16 len, u32 *data_out, u16 len_out, bool hs) 521 521 { 522 522 unsigned long flags; 523 - struct drm_device *dev = sender->dev; 523 + struct drm_device *dev; 524 524 int i; 525 525 u32 gen_data_reg; 526 526 int retry = MDFLD_DSI_READ_MAX_COUNT; ··· 529 529 DRM_ERROR("Invalid parameters\n"); 530 530 return -EINVAL; 531 531 } 532 + 533 + dev = sender->dev; 532 534 533 535 /** 534 536 * do reading.