tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

scsi: ufs: core: mcq: Fix ufshcd_mcq_sqe_search()

Fix the calculation of the utrd pointer. This patch addresses the following
Coverity complaint:

CID 1538170: (#1 of 1): Extra sizeof expression (SIZEOF_MISMATCH)
suspicious_pointer_arithmetic: Adding sq_head_slot * 32UL /* sizeof (struct
utp_transfer_req_desc) */ to pointer hwq->sqe_base_addr of type struct
utp_transfer_req_desc * is suspicious because adding an integral value to
this pointer automatically scales that value by the size, 32 bytes, of the
pointed-to type, struct utp_transfer_req_desc. Most likely, the
multiplication by sizeof (struct utp_transfer_req_desc) in this expression
is extraneous and should be eliminated.

Cc: Bao D. Nguyen <quic_nguyenb@quicinc.com>
Cc: Stanley Chu <stanley.chu@mediatek.com>
Cc: Can Guo <quic_cang@quicinc.com>
Fixes: 8d7290348992 ("scsi: ufs: mcq: Add supporting functions for MCQ abort")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20240410000751.1047758-1-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Bart Van Assche and committed by
Martin K. Petersen 3c5d0dce 0d8b637c

+1 -2
+1 -2
drivers/ufs/core/ufs-mcq.c
··· 601 601 addr = le64_to_cpu(cmd_desc_base_addr) & CQE_UCD_BA; 602 602 603 603 while (sq_head_slot != hwq->sq_tail_slot) { 604 - utrd = hwq->sqe_base_addr + 605 - sq_head_slot * sizeof(struct utp_transfer_req_desc); 604 + utrd = hwq->sqe_base_addr + sq_head_slot; 606 605 match = le64_to_cpu(utrd->command_desc_base_addr) & CQE_UCD_BA; 607 606 if (addr == match) { 608 607 ufshcd_mcq_nullify_sqe(utrd);