Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

nvmet: replace use of system_wq with system_percpu_wq

This patch continues the effort to refactor workqueue APIs, which has begun
with the changes introducing new workqueues and a new alloc_workqueue flag:

commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")

The point of the refactoring is to eventually alter the default behavior of
workqueues to become unbound by default so that their workload placement is
optimized by the scheduler.

Before that to happen, workqueue users must be converted to the better named
new workqueues with no intended behaviour changes:

system_wq -> system_percpu_wq
system_unbound_wq -> system_dfl_wq

This way the old obsolete workqueues (system_wq, system_unbound_wq) can be
removed in the future.

Link: https://lore.kernel.org/all/20250221112003.1dSuoGyc@linutronix.de/
Suggested-by: Tejun Heo <tj@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>

authored by

Marco Crivellari and committed by
Keith Busch
3d553be6 33eb4510

+2 -2
+1 -1
drivers/nvme/target/admin-cmd.c
··· 1605 1605 1606 1606 pr_debug("ctrl %d update keep-alive timer for %d secs\n", 1607 1607 ctrl->cntlid, ctrl->kato); 1608 - mod_delayed_work(system_wq, &ctrl->ka_work, ctrl->kato * HZ); 1608 + mod_delayed_work(system_percpu_wq, &ctrl->ka_work, ctrl->kato * HZ); 1609 1609 out: 1610 1610 nvmet_req_complete(req, status); 1611 1611 }
+1 -1
drivers/nvme/target/fabrics-cmd-auth.c
··· 390 390 req->sq->dhchap_step != NVME_AUTH_DHCHAP_MESSAGE_FAILURE2) { 391 391 unsigned long auth_expire_secs = ctrl->kato ? ctrl->kato : 120; 392 392 393 - mod_delayed_work(system_wq, &req->sq->auth_expired_work, 393 + mod_delayed_work(system_percpu_wq, &req->sq->auth_expired_work, 394 394 auth_expire_secs * HZ); 395 395 goto complete; 396 396 }