tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

clocksource/drivers/imx-tpm: Fix next event not taking effect sometime

The value written into the TPM CnV can only be updated into the hardware
when the counter increases. Additional writes to the CnV write buffer are
ignored until the register has been updated. Therefore, we need to check
if the CnV has been updated before continuing. This may require waiting for
1 counter cycle in the worst case.

Cc: stable@vger.kernel.org
Fixes: 059ab7b82eec ("clocksource/drivers/imx-tpm: Add imx tpm timer support")
Signed-off-by: Jacky Bai <ping.bai@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Jason Liu <jason.hui.liu@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20240725193355.1436005-2-Frank.Li@nxp.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

authored by

Jacky Bai and committed by
Daniel Lezcano 3d5c2f8e 5b8843fc

+8
+8
drivers/clocksource/timer-imx-tpm.c
··· 91 91 now = tpm_read_counter(); 92 92 93 93 /* 94 + * Need to wait CNT increase at least 1 cycle to make sure 95 + * the C0V has been updated into HW. 96 + */ 97 + if ((next & 0xffffffff) != readl(timer_base + TPM_C0V)) 98 + while (now == tpm_read_counter()) 99 + ; 100 + 101 + /* 94 102 * NOTE: We observed in a very small probability, the bus fabric 95 103 * contention between GPU and A7 may results a few cycles delay 96 104 * of writing CNT registers which may cause the min_delta event got