tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: txgbe: remove the redundant data return in SW-FW mailbox

For these two firmware mailbox commands, in txgbe_test_hostif() and
txgbe_set_phy_link_hostif(), there is no need to read data from the
buffer.

Under the current setting, OEM firmware will cause the driver to fail to
probe. Because OEM firmware returns more link information, with a larger
OEM structure txgbe_hic_ephy_getlink. However, the current driver does
not support the OEM function. So just fix it in the way that does not
involve reading the returned data.

Fixes: d84a3ff9aae8 ("net: txgbe: Restrict the use of mismatched FW versions")
Cc: stable@vger.kernel.org
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
Link: https://patch.msgid.link/2914AB0BC6158DDA+20260119065935.6015-1-jiawenwu@trustnetic.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Jiawen Wu and committed by
Jakub Kicinski 3d778e65 9d11e974

+2 -2
+2 -2
drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c
··· 70 70 buffer.hdr.cmd_or_resp.cmd_resv = FW_CEM_CMD_RESERVED; 71 71 72 72 return wx_host_interface_command(wx, (u32 *)&buffer, sizeof(buffer), 73 - WX_HI_COMMAND_TIMEOUT, true); 73 + WX_HI_COMMAND_TIMEOUT, false); 74 74 } 75 75 76 76 int txgbe_read_eeprom_hostif(struct wx *wx, ··· 148 148 buffer.duplex = duplex; 149 149 150 150 return wx_host_interface_command(wx, (u32 *)&buffer, sizeof(buffer), 151 - WX_HI_COMMAND_TIMEOUT, true); 151 + WX_HI_COMMAND_TIMEOUT, false); 152 152 } 153 153 154 154 static void txgbe_get_link_capabilities(struct wx *wx, int *speed,