tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mm: System without MMU do not need pte_mkwrite

The patch "thp: export maybe_mkwrite" (commit 14fd403f2146) breaks
systems without MMU.

Error log:

CC arch/microblaze/mm/init.o
In file included from include/linux/mman.h:14,
from arch/microblaze/mm/consistent.c:24:
include/linux/mm.h: In function 'maybe_mkwrite':
include/linux/mm.h:482: error: implicit declaration of function 'pte_mkwrite'
include/linux/mm.h:482: error: incompatible types in assignment

Signed-off-by: Michal Simek <monstr@monstr.eu>
CC: Andrea Arcangeli <aarcange@redhat.com>
Reviewed-by: Rik van Riel <riel@redhat.com>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Michal Simek and committed by
Linus Torvalds 3dece370 db9fd848

+2
+2
include/linux/mm.h
··· 470 470 page[1].lru.prev = (void *)order; 471 471 } 472 472 473 + #ifdef CONFIG_MMU 473 474 /* 474 475 * Do pte_mkwrite, but only if the vma says VM_WRITE. We do this when 475 476 * servicing faults for write access. In the normal case, do always want ··· 483 482 pte = pte_mkwrite(pte); 484 483 return pte; 485 484 } 485 + #endif 486 486 487 487 /* 488 488 * Multiple processes may "see" the same page. E.g. for untouched