tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mm/damon/tests/core-kunit: handle alloc failure on damos_test_commit_filter()

damon_test_commit_filter() is assuming all dynamic memory allocation in it
will succeed. Those are indeed likely in the real use cases since those
allocations are too small to fail, but theoretically those could fail. In
the case, inappropriate memory access can happen. Fix it by appropriately
cleanup pre-allocated memory and skip the execution of the remaining tests
in the failure cases.

Link: https://lkml.kernel.org/r/20251101182021.74868-15-sj@kernel.org
Fixes: f6a4a150f1ec ("mm/damon/tests/core-kunit: add damos_commit_filter test")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@google.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: <stable@vger.kernel.org> [6.18+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

SeongJae Park and committed by
Andrew Morton 3e5c4a1a 28ab2265

+9 -4
+9 -4
mm/damon/tests/core-kunit.h
··· 516 516 517 517 static void damos_test_commit_filter(struct kunit *test) 518 518 { 519 - struct damos_filter *src_filter = damos_new_filter( 520 - DAMOS_FILTER_TYPE_ANON, true, true); 521 - struct damos_filter *dst_filter = damos_new_filter( 522 - DAMOS_FILTER_TYPE_ACTIVE, false, false); 519 + struct damos_filter *src_filter, *dst_filter; 523 520 521 + src_filter = damos_new_filter(DAMOS_FILTER_TYPE_ANON, true, true); 522 + if (!src_filter) 523 + kunit_skip(test, "src filter alloc fail"); 524 + dst_filter = damos_new_filter(DAMOS_FILTER_TYPE_ACTIVE, false, false); 525 + if (!dst_filter) { 526 + damos_destroy_filter(src_filter); 527 + kunit_skip(test, "dst filter alloc fail"); 528 + } 524 529 damos_commit_filter(dst_filter, src_filter); 525 530 KUNIT_EXPECT_EQ(test, dst_filter->type, src_filter->type); 526 531 KUNIT_EXPECT_EQ(test, dst_filter->matching, src_filter->matching);