tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ASoC: update outdated comments for removed snd_soc_new_pcms()

The function snd_soc_new_pcms() was removed during the
multi-component refactoring in commit f0fba2ad1b6b ("ASoC:
multi-component - ASoC Multi-Component Support"). Its PCM creation
role is now handled by soc_new_pcm(), which was later moved to
sound/soc/soc-pcm.c by commit ddee627cf6bb ("ASoC: core - Separate
out PCM operations into new file.").

In fsl_dma.c, update the comment to reference soc_new_pcm(). Also
remove the stale paragraph about snd_dma_alloc_pages() always
allocating in lowmem, since commit e159704f7920 ("ASoC: fsl_dma:
Use managed buffer allocation") replaced that call with
snd_pcm_set_fixed_buffer_all().

In siu_pcm.c, remove the stale comment referencing
snd_soc_new_pcms() and the no-longer-existing socdev structure.

Assisted-by: unnamed:deepseek-v3.2 coccinelle
Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
Link: https://patch.msgid.link/20260324041400.16217-1-kexinsun@smail.nju.edu.cn
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Kexin Sun and committed by
Mark Brown 3e839947 5a306bef

+2 -9
+2 -8
sound/soc/fsl/fsl_dma.c
··· 267 267 /** 268 268 * fsl_dma_new: initialize this PCM driver. 269 269 * 270 - * This function is called when the codec driver calls snd_soc_new_pcms(), 271 - * once for each .dai_link in the machine driver's snd_soc_card 272 - * structure. 273 - * 274 - * snd_dma_alloc_pages() is just a front-end to dma_alloc_coherent(), which 275 - * (currently) always allocates the DMA buffer in lowmem, even if GFP_HIGHMEM 276 - * is specified. Therefore, any DMA buffers we allocate will always be in low 277 - * memory, but we support for 36-bit physical addresses anyway. 270 + * This function is called by soc_new_pcm(), once for each DAI link 271 + * in the machine driver's snd_soc_card structure. 278 272 * 279 273 * Regardless of where the memory is actually allocated, since the device can 280 274 * technically DMA to any 36-bit address, we do need to set the DMA mask to 36.
-1
sound/soc/renesas/siu_pcm.c
··· 483 483 static int siu_pcm_new(struct snd_soc_component *component, 484 484 struct snd_soc_pcm_runtime *rtd) 485 485 { 486 - /* card->dev == socdev->dev, see snd_soc_new_pcms() */ 487 486 struct snd_card *card = rtd->card->snd_card; 488 487 struct snd_pcm *pcm = rtd->pcm; 489 488 struct siu_info *info = siu_i2s_data;