Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

KHO: fix boot failure due to kmemleak access to non-PRESENT pages

When booting with debug_pagealloc=on while having:
CONFIG_KEXEC_HANDOVER_ENABLE_DEFAULT=y
CONFIG_DEBUG_KMEMLEAK_DEFAULT_OFF=n
the system fails to boot due to page faults during kmemleak scanning.

This occurs because:
With debug_pagealloc is enabled, __free_pages() invokes
debug_pagealloc_unmap_pages(), clearing the _PAGE_PRESENT bit for freed
pages in the kernel page table. KHO scratch areas are allocated from
memblock and noted by kmemleak. But these areas don't remain reserved but
released later to the page allocator using init_cma_reserved_pageblock().
This causes subsequent kmemleak scans access non-PRESENT pages, leading to
fatal page faults.

Mark scratch areas with kmemleak_ignore_phys() after they are allocated
from memblock to exclude them from kmemleak scanning before they are
released to buddy allocator to fix this.

[ran.xiaokai@zte.com.cn: add comment]
Link: https://lkml.kernel.org/r/20251127122700.103927-1-ranxiaokai627@163.com
Link: https://lkml.kernel.org/r/20251122182929.92634-1-ranxiaokai627@163.com
Signed-off-by: Ran Xiaokai <ran.xiaokai@zte.com.cn>
Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
Reviewed-by: Pratyush Yadav <pratyush@kernel.org>
Cc: Alexander Graf <graf@amazon.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Changyuan Lyu <changyuanl@google.com>
Cc: Pasha Tatashin <pasha.tatashin@soleen.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

Ran Xiaokai and committed by
Andrew Morton
40cd0e8d fb5c3644

+10
+10
kernel/liveupdate/kexec_handover.c
··· 11 11 12 12 #include <linux/cleanup.h> 13 13 #include <linux/cma.h> 14 + #include <linux/kmemleak.h> 14 15 #include <linux/count_zeros.h> 15 16 #include <linux/kexec.h> 16 17 #include <linux/kexec_handover.h> ··· 1370 1369 unsigned long count = kho_scratch[i].size >> PAGE_SHIFT; 1371 1370 unsigned long pfn; 1372 1371 1372 + /* 1373 + * When debug_pagealloc is enabled, __free_pages() clears the 1374 + * corresponding PRESENT bit in the kernel page table. 1375 + * Subsequent kmemleak scans of these pages cause the 1376 + * non-PRESENT page faults. 1377 + * Mark scratch areas with kmemleak_ignore_phys() to exclude 1378 + * them from kmemleak scanning. 1379 + */ 1380 + kmemleak_ignore_phys(kho_scratch[i].addr); 1373 1381 for (pfn = base_pfn; pfn < base_pfn + count; 1374 1382 pfn += pageblock_nr_pages) 1375 1383 init_cma_reserved_pageblock(pfn_to_page(pfn));