Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mfd: max8997: Remove unused function max8997_irq_exit()

Utilise devm_*() managed resource helpers for freeing IRQs instead.

Reported-by: Dr. David Alan Gilbert <linux@treblig.org>
Signed-off-by: Lee Jones <lee@kernel.org>

+4 -12
+4 -11
drivers/mfd/max8997-irq.c
··· 335 335 } 336 336 max8997->irq_domain = domain; 337 337 338 - ret = request_threaded_irq(max8997->irq, NULL, max8997_irq_thread, 338 + ret = devm_request_threaded_irq(max8997->dev, max8997->irq, NULL, 339 + max8997_irq_thread, 339 340 IRQF_TRIGGER_FALLING | IRQF_ONESHOT, 340 341 "max8997-irq", max8997); 341 342 ··· 349 348 if (!max8997->ono) 350 349 return 0; 351 350 352 - ret = request_threaded_irq(max8997->ono, NULL, max8997_irq_thread, 351 + ret = devm_request_threaded_irq(max8997->dev, max8997->ono, NULL, 352 + max8997_irq_thread, 353 353 IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING | 354 354 IRQF_ONESHOT, "max8997-ono", max8997); 355 355 ··· 359 357 max8997->ono, ret); 360 358 361 359 return 0; 362 - } 363 - 364 - void max8997_irq_exit(struct max8997_dev *max8997) 365 - { 366 - if (max8997->ono) 367 - free_irq(max8997->ono, max8997); 368 - 369 - if (max8997->irq) 370 - free_irq(max8997->irq, max8997); 371 360 }
-1
include/linux/mfd/max8997-private.h
··· 397 397 }; 398 398 399 399 extern int max8997_irq_init(struct max8997_dev *max8997); 400 - extern void max8997_irq_exit(struct max8997_dev *max8997); 401 400 extern int max8997_irq_resume(struct max8997_dev *max8997); 402 401 403 402 extern int max8997_read_reg(struct i2c_client *i2c, u8 reg, u8 *dest);