tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net/mlx5: fix unintentional sign extension on shift of dest_attr->vport.vhca_id

Shifting dest_attr->vport.vhca_id << 16 results in a promotion from an
unsigned 16 bit integer to a 32 bit signed integer, this is then sign
extended to a 64 bit unsigned long on 64 bitarchitectures. If vhca_id is
greater than 0x7fff then this leads to a sign extended result where all
the upper 32 bits of idx are set to 1. Fix this by casting vhca_id
to the same type as idx before performing the shift.

Fixes: 8e2e08a6d1e0 ("net/mlx5: fs, add support for dest vport HWS action")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Acked-by: Moshe Shemesh <moshe@nvidia.com>
Link: https://patch.msgid.link/20250116181700.96437-1-colin.i.king@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Colin Ian King and committed by
Jakub Kicinski 41c5d104 f16312b0

+1 -1
+1 -1
drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c
··· 417 417 vport_num = is_dest_type_uplink ? MLX5_VPORT_UPLINK : dest_attr->vport.num; 418 418 if (vhca_id_valid) { 419 419 dests_xa = &fs_ctx->hws_pool.vport_vhca_dests; 420 - idx = dest_attr->vport.vhca_id << 16 | vport_num; 420 + idx = (unsigned long)dest_attr->vport.vhca_id << 16 | vport_num; 421 421 } else { 422 422 dests_xa = &fs_ctx->hws_pool.vport_dests; 423 423 idx = vport_num;