Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
drm/msm/dp: drop struct msm_dp_panel_in
All other submodules pass arguments directly. Drop struct
msm_dp_panel_in that is used to wrap dp_panel's submodule args and pass
all data to msm_dp_panel_get() directly.
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Tested-by: Stephen Boyd <swboyd@chromium.org> # sc7180-trogdor
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/629055/
Link: https://lore.kernel.org/r/20241216-fd-dp-audio-fixup-v4-4-f8d1961cf22f@linaro.org
+11
-23
+1
-8
drivers/gpu/drm/msm/dp/dp_display.c
+1
-8
drivers/gpu/drm/msm/dp/dp_display.c
···
722
722
{
723
723
int rc = 0;
724
724
struct device *dev = &dp->msm_dp_display.pdev->dev;
725
-
struct msm_dp_panel_in panel_in = {
726
-
.dev = dev,
727
-
};
728
725
struct phy *phy;
729
726
730
727
phy = devm_phy_get(dev, "dp");
···
762
765
goto error_link;
763
766
}
764
767
765
-
panel_in.aux = dp->aux;
766
-
panel_in.catalog = dp->catalog;
767
-
panel_in.link = dp->link;
768
-
769
-
dp->panel = msm_dp_panel_get(&panel_in);
768
+
dp->panel = msm_dp_panel_get(dev, dp->aux, dp->link, dp->catalog);
770
769
if (IS_ERR(dp->panel)) {
771
770
rc = PTR_ERR(dp->panel);
772
771
DRM_ERROR("failed to initialize panel, rc = %d\n", rc);
+8
-7
drivers/gpu/drm/msm/dp/dp_panel.c
+8
-7
drivers/gpu/drm/msm/dp/dp_panel.c
···
475
475
return 0;
476
476
}
477
477
478
-
struct msm_dp_panel *msm_dp_panel_get(struct msm_dp_panel_in *in)
478
+
struct msm_dp_panel *msm_dp_panel_get(struct device *dev, struct drm_dp_aux *aux,
479
+
struct msm_dp_link *link, struct msm_dp_catalog *catalog)
479
480
{
480
481
struct msm_dp_panel_private *panel;
481
482
struct msm_dp_panel *msm_dp_panel;
482
483
int ret;
483
484
484
-
if (!in->dev || !in->catalog || !in->aux || !in->link) {
485
+
if (!dev || !catalog || !aux || !link) {
485
486
DRM_ERROR("invalid input\n");
486
487
return ERR_PTR(-EINVAL);
487
488
}
488
489
489
-
panel = devm_kzalloc(in->dev, sizeof(*panel), GFP_KERNEL);
490
+
panel = devm_kzalloc(dev, sizeof(*panel), GFP_KERNEL);
490
491
if (!panel)
491
492
return ERR_PTR(-ENOMEM);
492
493
493
-
panel->dev = in->dev;
494
-
panel->aux = in->aux;
495
-
panel->catalog = in->catalog;
496
-
panel->link = in->link;
494
+
panel->dev = dev;
495
+
panel->aux = aux;
496
+
panel->catalog = catalog;
497
+
panel->link = link;
497
498
498
499
msm_dp_panel = &panel->msm_dp_panel;
499
500
msm_dp_panel->max_bw_code = DP_LINK_BW_8_1;
+2
-8
drivers/gpu/drm/msm/dp/dp_panel.h
+2
-8
drivers/gpu/drm/msm/dp/dp_panel.h
···
21
21
bool out_fmt_is_yuv_420;
22
22
};
23
23
24
-
struct msm_dp_panel_in {
25
-
struct device *dev;
26
-
struct drm_dp_aux *aux;
27
-
struct msm_dp_link *link;
28
-
struct msm_dp_catalog *catalog;
29
-
};
30
-
31
24
struct msm_dp_panel_psr {
32
25
u8 version;
33
26
u8 capabilities;
···
84
91
lane_count == 4);
85
92
}
86
93
87
-
struct msm_dp_panel *msm_dp_panel_get(struct msm_dp_panel_in *in);
94
+
struct msm_dp_panel *msm_dp_panel_get(struct device *dev, struct drm_dp_aux *aux,
95
+
struct msm_dp_link *link, struct msm_dp_catalog *catalog);
88
96
void msm_dp_panel_put(struct msm_dp_panel *msm_dp_panel);
89
97
#endif /* _DP_PANEL_H_ */