tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

kfifo: don't include dma-mapping.h in kfifo.h

Nothing in kfifo.h directly needs dma-mapping.h, only two macros
use DMA_MAPPING_ERROR when actually instantiated. Drop the
dma-mapping.h include to reduce include bloat.

Add an explicity <linux/io.h> include to drivers/mailbox/omap-mailbox.c
as that file uses __raw_readl and __raw_writel through a complicated
include chain involving <linux/dma-mapping.h>

Fixes: d52b761e4b1a ("kfifo: add kfifo_dma_out_prepare_mapped()")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20241023055317.313234-1-hch@lst.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Christoph Hellwig and committed by
Greg Kroah-Hartman 44059790 ec8c17e5

+2 -1
+1
drivers/mailbox/omap-mailbox.c
··· 15 15 #include <linux/slab.h> 16 16 #include <linux/kfifo.h> 17 17 #include <linux/err.h> 18 + #include <linux/io.h> 18 19 #include <linux/module.h> 19 20 #include <linux/of.h> 20 21 #include <linux/platform_device.h>
-1
include/linux/kfifo.h
··· 37 37 */ 38 38 39 39 #include <linux/array_size.h> 40 - #include <linux/dma-mapping.h> 41 40 #include <linux/spinlock.h> 42 41 #include <linux/stddef.h> 43 42 #include <linux/types.h>
+1
samples/kfifo/dma-example.c
··· 9 9 #include <linux/kfifo.h> 10 10 #include <linux/module.h> 11 11 #include <linux/scatterlist.h> 12 + #include <linux/dma-mapping.h> 12 13 13 14 /* 14 15 * This module shows how to handle fifo dma operations.