tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

hrtimers: Introduce hrtimer_setup_on_stack()

To initialize hrtimer on stack, hrtimer_init_on_stack() needs to be called
and also hrtimer::function must be set. This is error-prone and awkward to
use.

Introduce hrtimer_setup_on_stack() which does both of these things, so that
users of hrtimer can be simplified.

The new setup function also has a sanity check for the provided function
pointer. If NULL, a warning is emitted and a dummy callback installed.

hrtimer_init_on_stack() will be removed as soon as all of its users have
been converted to the new function.

Signed-off-by: Nam Cao <namcao@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/4b05e2ab3a82c517adf67fabc0f0cd8fe118b97c.1730386209.git.namcao@linutronix.de

authored by

Nam Cao and committed by
Thomas Gleixner 444cb7db 908a1d77

+22
+3
include/linux/hrtimer.h
··· 232 232 clockid_t clock_id, enum hrtimer_mode mode); 233 233 extern void hrtimer_init_on_stack(struct hrtimer *timer, clockid_t which_clock, 234 234 enum hrtimer_mode mode); 235 + extern void hrtimer_setup_on_stack(struct hrtimer *timer, 236 + enum hrtimer_restart (*function)(struct hrtimer *), 237 + clockid_t clock_id, enum hrtimer_mode mode); 235 238 extern void hrtimer_init_sleeper_on_stack(struct hrtimer_sleeper *sl, 236 239 clockid_t clock_id, 237 240 enum hrtimer_mode mode);
+19
kernel/time/hrtimer.c
··· 1646 1646 } 1647 1647 EXPORT_SYMBOL_GPL(hrtimer_init_on_stack); 1648 1648 1649 + /** 1650 + * hrtimer_setup_on_stack - initialize a timer on stack memory 1651 + * @timer: The timer to be initialized 1652 + * @function: the callback function 1653 + * @clock_id: The clock to be used 1654 + * @mode: The timer mode 1655 + * 1656 + * Similar to hrtimer_setup(), except that this one must be used if struct hrtimer is in stack 1657 + * memory. 1658 + */ 1659 + void hrtimer_setup_on_stack(struct hrtimer *timer, 1660 + enum hrtimer_restart (*function)(struct hrtimer *), 1661 + clockid_t clock_id, enum hrtimer_mode mode) 1662 + { 1663 + debug_init_on_stack(timer, clock_id, mode); 1664 + __hrtimer_setup(timer, function, clock_id, mode); 1665 + } 1666 + EXPORT_SYMBOL_GPL(hrtimer_setup_on_stack); 1667 + 1649 1668 /* 1650 1669 * A timer is active, when it is enqueued into the rbtree or the 1651 1670 * callback function is running or it's in the state of being migrated