Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
soc/tegra: fuse: Use dev_err_probe for probe failures
Currently, in tegra_fuse_probe() if clock/reset get fails, then the
driver prints an error if the error is not caused by -EPROBE_DEFER.
This can be improved by using dev_err_probe() instead.
So, return dev_err_probe() if clock/reset get fails.
Signed-off-by: Kartik <kkartik@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
authored by
Kartik
and committed by
Thierry Reding
4569e604
7092e9b3
+4
-13
+4
-13
drivers/soc/tegra/fuse/fuse-tegra.c
+4
-13
drivers/soc/tegra/fuse/fuse-tegra.c
···
131
131
fuse->phys = res->start;
132
132
133
133
fuse->clk = devm_clk_get(&pdev->dev, "fuse");
134
-
if (IS_ERR(fuse->clk)) {
135
-
if (PTR_ERR(fuse->clk) != -EPROBE_DEFER)
136
-
dev_err(&pdev->dev, "failed to get FUSE clock: %ld",
137
-
PTR_ERR(fuse->clk));
138
-
139
-
return PTR_ERR(fuse->clk);
140
-
}
134
+
if (IS_ERR(fuse->clk))
135
+
return dev_err_probe(&pdev->dev, PTR_ERR(fuse->clk), "failed to get FUSE clock\n");
141
136
142
137
platform_set_drvdata(pdev, fuse);
143
138
fuse->dev = &pdev->dev;
···
174
179
}
175
180
176
181
fuse->rst = devm_reset_control_get_optional(&pdev->dev, "fuse");
177
-
if (IS_ERR(fuse->rst)) {
178
-
err = PTR_ERR(fuse->rst);
179
-
dev_err(&pdev->dev, "failed to get FUSE reset: %pe\n",
180
-
fuse->rst);
181
-
return err;
182
-
}
182
+
if (IS_ERR(fuse->rst))
183
+
return dev_err_probe(&pdev->dev, PTR_ERR(fuse->rst), "failed to get FUSE reset\n");
183
184
184
185
/*
185
186
* FUSE clock is enabled at a boot time, hence this resume/suspend