Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
drm/vc4: kms: Warn if we have an incompatible muxing setup
The documentation explicitly states we must prevent the output
2 and 3 from feeding from the same HVS channel.
Let's add a warning to make some noise if we ever find ourselves in such
a case.
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20220328153659.2382206-6-maxime@cerno.tech
+4
+4
drivers/gpu/drm/vc4/vc4_kms.c
+4
drivers/gpu/drm/vc4/vc4_kms.c
···
290
290
291
291
switch (vc4_crtc->data->hvs_output) {
292
292
case 2:
293
+
drm_WARN_ON(&vc4->base,
294
+
VC4_GET_FIELD(HVS_READ(SCALER_DISPCTRL),
295
+
SCALER_DISPCTRL_DSP3_MUX) == channel);
296
+
293
297
mux = (channel == 2) ? 0 : 1;
294
298
reg = HVS_READ(SCALER_DISPECTRL);
295
299
HVS_WRITE(SCALER_DISPECTRL,