Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
tools/rtla: Remove unneeded nr_cpus from for_each_monitored_cpu
nr_cpus does not change at runtime, so passing it through the macro
argument is unnecessary.
Remove the argument and use the global nr_cpus instead.
Signed-off-by: Costa Shulyupin <costa.shul@redhat.com>
Link: https://lore.kernel.org/r/20260306194953.2511960-5-costa.shul@redhat.com
Signed-off-by: Tomas Glozar <tglozar@redhat.com>
authored by
Costa Shulyupin
and committed by
Tomas Glozar
458c9519
caf3fc0f
+20
-21
+1
-1
tools/tracing/rtla/src/common.h
+1
-1
tools/tracing/rtla/src/common.h
+7
-8
tools/tracing/rtla/src/osnoise_hist.c
+7
-8
tools/tracing/rtla/src/osnoise_hist.c
···
244
244
if (!params->common.hist.no_index)
245
245
trace_seq_printf(s, "Index");
246
246
247
-
for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) {
247
+
for_each_monitored_cpu(cpu, ¶ms->common) {
248
248
249
249
if (!data->hist[cpu].count)
250
250
continue;
···
273
273
if (!params->common.hist.no_index)
274
274
trace_seq_printf(trace->seq, "count:");
275
275
276
-
for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) {
277
-
276
+
for_each_monitored_cpu(cpu, ¶ms->common) {
278
277
if (!data->hist[cpu].count)
279
278
continue;
280
279
···
284
285
if (!params->common.hist.no_index)
285
286
trace_seq_printf(trace->seq, "min: ");
286
287
287
-
for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) {
288
+
for_each_monitored_cpu(cpu, ¶ms->common) {
288
289
289
290
if (!data->hist[cpu].count)
290
291
continue;
···
297
298
if (!params->common.hist.no_index)
298
299
trace_seq_printf(trace->seq, "avg: ");
299
300
300
-
for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) {
301
+
for_each_monitored_cpu(cpu, ¶ms->common) {
301
302
302
303
if (!data->hist[cpu].count)
303
304
continue;
···
313
314
if (!params->common.hist.no_index)
314
315
trace_seq_printf(trace->seq, "max: ");
315
316
316
-
for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) {
317
+
for_each_monitored_cpu(cpu, ¶ms->common) {
317
318
318
319
if (!data->hist[cpu].count)
319
320
continue;
···
348
349
trace_seq_printf(trace->seq, "%-6d",
349
350
bucket * data->bucket_size);
350
351
351
-
for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) {
352
+
for_each_monitored_cpu(cpu, ¶ms->common) {
352
353
353
354
if (!data->hist[cpu].count)
354
355
continue;
···
384
385
if (!params->common.hist.no_index)
385
386
trace_seq_printf(trace->seq, "over: ");
386
387
387
-
for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) {
388
+
for_each_monitored_cpu(cpu, ¶ms->common) {
388
389
389
390
if (!data->hist[cpu].count)
390
391
continue;
+1
-1
tools/tracing/rtla/src/osnoise_top.c
+1
-1
tools/tracing/rtla/src/osnoise_top.c
+2
-2
tools/tracing/rtla/src/timerlat.c
+2
-2
tools/tracing/rtla/src/timerlat.c
···
115
115
return -1;
116
116
}
117
117
118
-
for_each_monitored_cpu(i, nr_cpus, ¶ms->common) {
118
+
for_each_monitored_cpu(i, ¶ms->common) {
119
119
if (save_cpu_idle_disable_state(i) < 0) {
120
120
err_msg("Could not save cpu idle state.\n");
121
121
return -1;
···
218
218
if (dma_latency_fd >= 0)
219
219
close(dma_latency_fd);
220
220
if (params->deepest_idle_state >= -1) {
221
-
for_each_monitored_cpu(i, nr_cpus, ¶ms->common) {
221
+
for_each_monitored_cpu(i, ¶ms->common) {
222
222
restore_cpu_idle_disable_state(i);
223
223
}
224
224
}
+8
-8
tools/tracing/rtla/src/timerlat_hist.c
+8
-8
tools/tracing/rtla/src/timerlat_hist.c
···
298
298
if (!params->common.hist.no_index)
299
299
trace_seq_printf(s, "Index");
300
300
301
-
for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) {
301
+
for_each_monitored_cpu(cpu, ¶ms->common) {
302
302
303
303
if (!data->hist[cpu].irq_count && !data->hist[cpu].thread_count)
304
304
continue;
···
350
350
if (!params->common.hist.no_index)
351
351
trace_seq_printf(trace->seq, "count:");
352
352
353
-
for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) {
353
+
for_each_monitored_cpu(cpu, ¶ms->common) {
354
354
355
355
if (!data->hist[cpu].irq_count && !data->hist[cpu].thread_count)
356
356
continue;
···
372
372
if (!params->common.hist.no_index)
373
373
trace_seq_printf(trace->seq, "min: ");
374
374
375
-
for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) {
375
+
for_each_monitored_cpu(cpu, ¶ms->common) {
376
376
377
377
if (!data->hist[cpu].irq_count && !data->hist[cpu].thread_count)
378
378
continue;
···
400
400
if (!params->common.hist.no_index)
401
401
trace_seq_printf(trace->seq, "avg: ");
402
402
403
-
for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) {
403
+
for_each_monitored_cpu(cpu, ¶ms->common) {
404
404
405
405
if (!data->hist[cpu].irq_count && !data->hist[cpu].thread_count)
406
406
continue;
···
428
428
if (!params->common.hist.no_index)
429
429
trace_seq_printf(trace->seq, "max: ");
430
430
431
-
for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) {
431
+
for_each_monitored_cpu(cpu, ¶ms->common) {
432
432
433
433
if (!data->hist[cpu].irq_count && !data->hist[cpu].thread_count)
434
434
continue;
···
473
473
sum.min_thread = ~0;
474
474
sum.min_user = ~0;
475
475
476
-
for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) {
476
+
for_each_monitored_cpu(cpu, ¶ms->common) {
477
477
478
478
if (!data->hist[cpu].irq_count && !data->hist[cpu].thread_count)
479
479
continue;
···
620
620
trace_seq_printf(trace->seq, "%-6d",
621
621
bucket * data->bucket_size);
622
622
623
-
for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) {
623
+
for_each_monitored_cpu(cpu, ¶ms->common) {
624
624
625
625
if (!data->hist[cpu].irq_count && !data->hist[cpu].thread_count)
626
626
continue;
···
658
658
if (!params->common.hist.no_index)
659
659
trace_seq_printf(trace->seq, "over: ");
660
660
661
-
for_each_monitored_cpu(cpu, nr_cpus, ¶ms->common) {
661
+
for_each_monitored_cpu(cpu, ¶ms->common) {
662
662
663
663
if (!data->hist[cpu].irq_count && !data->hist[cpu].thread_count)
664
664
continue;
+1
-1
tools/tracing/rtla/src/timerlat_top.c
+1
-1
tools/tracing/rtla/src/timerlat_top.c