tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

platform/x86: x86-android-tablets: Fix Lenovo Yoga Tablet 2 830F/L vs 1050F/L detection

gpio_crystalcove pin 10 is already in input mode and passing GPIOD_IN
when requesting the GPIO changes its pull-up/-down settings causing
the 830F/L to get misdetected as 1050F/L.

Switch to using GPIOD_ASIS when requesting the GPIO to fix
the misdetection.

Fixes: 4014ae236b1d ("platform/x86: x86-android-tablets: Stop using gpiolib private APIs")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20230915214933.62595-1-hdegoede@redhat.com

Hans de Goede 45ae16ec 318d9784

+1 -1
+1 -1
drivers/platform/x86/x86-android-tablets/lenovo.c
··· 436 436 437 437 /* Use PMIC GPIO 10 bootstrap pin to differentiate 830 vs 1050 */ 438 438 ret = x86_android_tablet_get_gpiod("gpio_crystalcove", 10, "yoga_bootstrap", 439 - false, GPIOD_IN, &gpiod); 439 + false, GPIOD_ASIS, &gpiod); 440 440 if (ret) 441 441 return ret; 442 442