tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: ethernet: ti: cpsw: fix the comment regarding VLAN-aware ALE

In all 3 cases (cpsw, cpsw-new, am65-cpsw) ALE is being configured in
VLAN-aware mode, while the comment states the opposite. Seems to be a typo
copy-pasted from one driver to another. Fix the commend which has been
puzzling some people (including me) for at least a decade.

Link: https://lore.kernel.org/linux-arm-kernel/4699400.vD3TdgH1nR@localhost/
Link: https://lore.kernel.org/netdev/0106ce78-c83f-4552-a234-1bf7a33f1ed1@kernel.org/
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250109214219.123767-1-alexander.sverdlin@siemens.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Alexander Sverdlin and committed by
Jakub Kicinski 460b5283 06cc8786

+3 -3
+1 -1
drivers/net/ethernet/ti/am65-cpsw-nuss.c
··· 762 762 ALE_DEFAULT_THREAD_ID, 0); 763 763 cpsw_ale_control_set(common->ale, HOST_PORT_NUM, 764 764 ALE_DEFAULT_THREAD_ENABLE, 1); 765 - /* switch to vlan unaware mode */ 765 + /* switch to vlan aware mode */ 766 766 cpsw_ale_control_set(common->ale, HOST_PORT_NUM, ALE_VLAN_AWARE, 1); 767 767 cpsw_ale_control_set(common->ale, HOST_PORT_NUM, 768 768 ALE_PORT_STATE, ALE_PORT_STATE_FORWARD);
+1 -1
drivers/net/ethernet/ti/cpsw.c
··· 686 686 soft_reset("cpsw", &cpsw->regs->soft_reset); 687 687 cpsw_ale_start(cpsw->ale); 688 688 689 - /* switch to vlan unaware mode */ 689 + /* switch to vlan aware mode */ 690 690 cpsw_ale_control_set(cpsw->ale, HOST_PORT_NUM, ALE_VLAN_AWARE, 691 691 CPSW_ALE_VLAN_AWARE); 692 692 control_reg = readl(&cpsw->regs->control);
+1 -1
drivers/net/ethernet/ti/cpsw_new.c
··· 554 554 soft_reset("cpsw", &cpsw->regs->soft_reset); 555 555 cpsw_ale_start(cpsw->ale); 556 556 557 - /* switch to vlan unaware mode */ 557 + /* switch to vlan aware mode */ 558 558 cpsw_ale_control_set(cpsw->ale, HOST_PORT_NUM, ALE_VLAN_AWARE, 559 559 CPSW_ALE_VLAN_AWARE); 560 560 control_reg = readl(&cpsw->regs->control);