tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

io_uring/cmd_net: fix wrong argument types for skb_queue_splice()

If timestamp retriving needs to be retried and the local list of
SKB's already has entries, then it's spliced back into the socket
queue. However, the arguments for the splice helper are transposed,
causing exactly the wrong direction of splicing into the on-stack
list. Fix that up.

Cc: stable@vger.kernel.org
Reported-by: Google Big Sleep <big-sleep-vuln-reports+bigsleep-462435176@google.com>
Fixes: 9e4ed359b8ef ("io_uring/netcmd: add tx timestamping cmd support")
Signed-off-by: Jens Axboe <axboe@kernel.dk>

Jens Axboe 46447367 2d0e88f3

+1 -1
+1 -1
io_uring/cmd_net.c
··· 127 127 128 128 if (!unlikely(skb_queue_empty(&list))) { 129 129 scoped_guard(spinlock_irqsave, &q->lock) 130 - skb_queue_splice(q, &list); 130 + skb_queue_splice(&list, q); 131 131 } 132 132 return -EAGAIN; 133 133 }