tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: phy: qca807x: Drop unnecessary and broken DT validation

The check for "leds" and "gpio-controller" both being present is never
true because "leds" is a node, not a property. This could be fixed
with a check for child node, but there's really no need for the kernel
to validate a DT. Just continue ignoring the LEDs if GPIOs are present.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Link: https://patch.msgid.link/20240731201703.1842022-2-robh@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Rob Herring (Arm) and committed by
Jakub Kicinski 46e6acfe 5fcf0801

-10
-10
drivers/net/phy/qcom/qca807x.c
··· 733 733 "qcom,dac-disable-bias-current-tweak"); 734 734 735 735 #if IS_ENABLED(CONFIG_GPIOLIB) 736 - /* Make sure we don't have mixed leds node and gpio-controller 737 - * to prevent registering leds and having gpio-controller usage 738 - * conflicting with them. 739 - */ 740 - if (of_find_property(node, "leds", NULL) && 741 - of_find_property(node, "gpio-controller", NULL)) { 742 - phydev_err(phydev, "Invalid property detected. LEDs and gpio-controller are mutually exclusive."); 743 - return -EINVAL; 744 - } 745 - 746 736 /* Do not register a GPIO controller unless flagged for it */ 747 737 if (of_property_read_bool(node, "gpio-controller")) { 748 738 ret = qca807x_gpio(phydev);