Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

crypto: caam - Replace snprintf with strscpy in caam_hash_alloc

Replace snprintf("%s", ...) with the faster and more direct strscpy().

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

authored by

Thorsten Blum and committed by
Herbert Xu
476466e9 a4559a2b

+9 -16
+5 -8
drivers/crypto/caam/caamalg_qi2.c
··· 19 19 #include <linux/dma-mapping.h> 20 20 #include <linux/fsl/mc.h> 21 21 #include <linux/kernel.h> 22 + #include <linux/string.h> 22 23 #include <linux/string_choices.h> 23 24 #include <soc/fsl/dpaa2-io.h> 24 25 #include <soc/fsl/dpaa2-fd.h> ··· 4645 4644 alg = &halg->halg.base; 4646 4645 4647 4646 if (keyed) { 4648 - snprintf(alg->cra_name, CRYPTO_MAX_ALG_NAME, "%s", 4649 - template->hmac_name); 4650 - snprintf(alg->cra_driver_name, CRYPTO_MAX_ALG_NAME, "%s", 4651 - template->hmac_driver_name); 4647 + strscpy(alg->cra_name, template->hmac_name); 4648 + strscpy(alg->cra_driver_name, template->hmac_driver_name); 4652 4649 t_alg->is_hmac = true; 4653 4650 } else { 4654 - snprintf(alg->cra_name, CRYPTO_MAX_ALG_NAME, "%s", 4655 - template->name); 4656 - snprintf(alg->cra_driver_name, CRYPTO_MAX_ALG_NAME, "%s", 4657 - template->driver_name); 4651 + strscpy(alg->cra_name, template->name); 4652 + strscpy(alg->cra_driver_name, template->driver_name); 4658 4653 t_alg->ahash_alg.setkey = NULL; 4659 4654 t_alg->is_hmac = false; 4660 4655 }
+4 -8
drivers/crypto/caam/caamhash.c
··· 1913 1913 alg = &halg->halg.base; 1914 1914 1915 1915 if (keyed) { 1916 - snprintf(alg->cra_name, CRYPTO_MAX_ALG_NAME, "%s", 1917 - template->hmac_name); 1918 - snprintf(alg->cra_driver_name, CRYPTO_MAX_ALG_NAME, "%s", 1919 - template->hmac_driver_name); 1916 + strscpy(alg->cra_name, template->hmac_name); 1917 + strscpy(alg->cra_driver_name, template->hmac_driver_name); 1920 1918 t_alg->is_hmac = true; 1921 1919 } else { 1922 - snprintf(alg->cra_name, CRYPTO_MAX_ALG_NAME, "%s", 1923 - template->name); 1924 - snprintf(alg->cra_driver_name, CRYPTO_MAX_ALG_NAME, "%s", 1925 - template->driver_name); 1920 + strscpy(alg->cra_name, template->name); 1921 + strscpy(alg->cra_driver_name, template->driver_name); 1926 1922 halg->setkey = NULL; 1927 1923 t_alg->is_hmac = false; 1928 1924 }