tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

sched/deadline: Remove unnecessary comment in dl_add_task_root_domain()

The comments above dl_get_task_effective_cpus() and
dl_add_task_root_domain() already explain how to fetch a valid
root domain and protect against races. There's no need to repeat
this inside dl_add_task_root_domain(). Remove the redundant comment
to keep the code clean.

No functional change.

Signed-off-by: Pingfan Liu <piliu@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Juri Lelli <juri.lelli@redhat.com>
Acked-by: Waiman Long <longman@redhat.com>
Link: https://patch.msgid.link/20251125032630.8746-2-piliu@redhat.com

authored by

Pingfan Liu and committed by
Peter Zijlstra 479972ef 0f61b186

-9
-9
kernel/sched/deadline.c
··· 3162 3162 return; 3163 3163 } 3164 3164 3165 - /* 3166 - * Get an active rq, whose rq->rd traces the correct root 3167 - * domain. 3168 - * Ideally this would be under cpuset reader lock until rq->rd is 3169 - * fetched. However, sleepable locks cannot nest inside pi_lock, so we 3170 - * rely on the caller of dl_add_task_root_domain() holds 'cpuset_mutex' 3171 - * to guarantee the CPU stays in the cpuset. 3172 - */ 3173 3165 dl_get_task_effective_cpus(p, msk); 3174 3166 cpu = cpumask_first_and(cpu_active_mask, msk); 3175 3167 BUG_ON(cpu >= nr_cpu_ids); 3176 3168 rq = cpu_rq(cpu); 3177 3169 dl_b = &rq->rd->dl_bw; 3178 - /* End of fetching rd */ 3179 3170 3180 3171 raw_spin_lock(&dl_b->lock); 3181 3172 __dl_add(dl_b, p->dl.dl_bw, cpumask_weight(rq->rd->span));