tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

media: i2c: ov9282: add output enable register definitions

Add #define's for the output enable registers (0x3004, 0x3005, 0x3006),
also known as SC_CTRL_04, SC_CTRL_05, SC_CTRL_04. Use those register
definitions instead of the raw values in the `common_regs` struct.

All values are based on the OV9281 datasheet v1.53 (january 2019).

Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: Richard Leitner <richard.leitner@linux.dev>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>

authored by

Richard Leitner and committed by
Hans Verkuil 47bc0d29 fa0e06f2

+26 -3
+26 -3
drivers/media/i2c/ov9282.c
··· 37 37 #define OV9282_REG_ID 0x300a 38 38 #define OV9282_ID 0x9281 39 39 40 + /* Output enable registers */ 41 + #define OV9282_REG_OUTPUT_ENABLE4 0x3004 42 + #define OV9282_OUTPUT_ENABLE4_GPIO2 BIT(1) 43 + #define OV9282_OUTPUT_ENABLE4_D9 BIT(0) 44 + 45 + #define OV9282_REG_OUTPUT_ENABLE5 0x3005 46 + #define OV9282_OUTPUT_ENABLE5_D8 BIT(7) 47 + #define OV9282_OUTPUT_ENABLE5_D7 BIT(6) 48 + #define OV9282_OUTPUT_ENABLE5_D6 BIT(5) 49 + #define OV9282_OUTPUT_ENABLE5_D5 BIT(4) 50 + #define OV9282_OUTPUT_ENABLE5_D4 BIT(3) 51 + #define OV9282_OUTPUT_ENABLE5_D3 BIT(2) 52 + #define OV9282_OUTPUT_ENABLE5_D2 BIT(1) 53 + #define OV9282_OUTPUT_ENABLE5_D1 BIT(0) 54 + 55 + #define OV9282_REG_OUTPUT_ENABLE6 0x3006 56 + #define OV9282_OUTPUT_ENABLE6_D0 BIT(7) 57 + #define OV9282_OUTPUT_ENABLE6_PCLK BIT(6) 58 + #define OV9282_OUTPUT_ENABLE6_HREF BIT(5) 59 + #define OV9282_OUTPUT_ENABLE6_STROBE BIT(3) 60 + #define OV9282_OUTPUT_ENABLE6_ILPWM BIT(2) 61 + #define OV9282_OUTPUT_ENABLE6_VSYNC BIT(1) 62 + 40 63 /* Exposure control */ 41 64 #define OV9282_REG_EXPOSURE 0x3500 42 65 #define OV9282_EXPOSURE_MIN 1 ··· 236 213 {0x0302, 0x32}, 237 214 {0x030e, 0x02}, 238 215 {0x3001, 0x00}, 239 - {0x3004, 0x00}, 240 - {0x3005, 0x00}, 241 - {0x3006, 0x04}, 216 + {OV9282_REG_OUTPUT_ENABLE4, 0x00}, 217 + {OV9282_REG_OUTPUT_ENABLE5, 0x00}, 218 + {OV9282_REG_OUTPUT_ENABLE6, OV9282_OUTPUT_ENABLE6_ILPWM}, 242 219 {0x3011, 0x0a}, 243 220 {0x3013, 0x18}, 244 221 {0x301c, 0xf0},