Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/msm/gem: fix error handling in msm_ioctl_gem_info_get_metadata()

msm_ioctl_gem_info_get_metadata() always returns 0 regardless of
errors. When copy_to_user() fails or the user buffer is too small,
the error code stored in ret is ignored because the function
unconditionally returns 0. This causes userspace to believe the
ioctl succeeded when it did not.

Additionally, kmemdup() can return NULL on allocation failure, but
the return value is not checked. This leads to a NULL pointer
dereference in the subsequent copy_to_user() call.

Add the missing NULL check for kmemdup() and return ret instead of 0.

Note that the SET counterpart (msm_ioctl_gem_info_set_metadata)
correctly returns ret.

Fixes: 9902cb999e4e ("drm/msm/gem: Add metadata")
Cc: stable@vger.kernel.org
Signed-off-by: Yasuaki Torimaru <yasuakitorimaru@gmail.com>
Patchwork: https://patchwork.freedesktop.org/patch/714478/
Message-ID: <20260325114635.383241-1-yasuakitorimaru@gmail.com>
Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>

authored by

Yasuaki Torimaru and committed by
Rob Clark
47cbfe26 cc83f71c

+6 -1
+6 -1
drivers/gpu/drm/msm/msm_drv.c
··· 536 536 len = msm_obj->metadata_size; 537 537 buf = kmemdup(msm_obj->metadata, len, GFP_KERNEL); 538 538 539 + if (!buf) { 540 + msm_gem_unlock(obj); 541 + return -ENOMEM; 542 + } 543 + 539 544 msm_gem_unlock(obj); 540 545 541 546 if (*metadata_size < len) { ··· 553 548 554 549 kfree(buf); 555 550 556 - return 0; 551 + return ret; 557 552 } 558 553 559 554 static int msm_ioctl_gem_info(struct drm_device *dev, void *data,